Adds missing JavaScript codeblock in Opengraph Image API reference #50996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotny
requested review from
timneutkens,
ijjk,
shuding,
styfle and
huozhi
as code owners
ijjk
reviewed
Jun 8, 2023
docs/02-app/02-api-reference/02-file-conventions/01-metadata/opengraph-image.mdx
Outdated
Show resolved
Hide resolved
delbaoliveira
previously approved these changes
Jun 8, 2023
docs/02-app/02-api-reference/02-file-conventions/01-metadata/opengraph-image.mdx
Outdated
Show resolved
Hide resolved
docs/02-app/02-api-reference/02-file-conventions/01-metadata/opengraph-image.mdx
Outdated
Show resolved
Hide resolved
docs/02-app/02-api-reference/02-file-conventions/01-metadata/opengraph-image.mdx
Outdated
Show resolved
Hide resolved
docs/02-app/02-api-reference/02-file-conventions/01-metadata/opengraph-image.mdx
Outdated
Show resolved
Hide resolved
styfle
previously approved these changes
Jun 8, 2023
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
|
@styfle @delbaoliveira changes made. Ready for re-review. |
styfle
approved these changes
Jun 8, 2023
kodiakhq
bot
deleted the
adds-missing-js-codeblock-in-opengraph-image-api-reference
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes JavaScript examples to use
.jsxextensions so IDEs better recognize the JSX allowed as the first argument toImageResponse.Fixes #50141