New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes codeblock language and filename extensions consistent #51056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotny
requested review from
timneutkens,
ijjk,
shuding,
styfle and
huozhi
as code owners
June 9, 2023 17:32
ijjk
added
area: documentation
Font (next/font)
Related to Next.js Font Optimization.
labels
Jun 9, 2023
styfle
reviewed
Jun 9, 2023
styfle
reviewed
Jun 9, 2023
styfle
reviewed
Jun 9, 2023
docs/03-pages/01-building-your-application/05-optimizing/10-testing.mdx
Outdated
Show resolved
Hide resolved
styfle
reviewed
Jun 9, 2023
docs/02-app/01-building-your-application/01-routing/05-dynamic-routes.mdx
Show resolved
Hide resolved
styfle
reviewed
Jun 9, 2023
docs/02-app/01-building-your-application/01-routing/08-parallel-routes.mdx
Show resolved
Hide resolved
styfle
reviewed
Jun 9, 2023
docs/02-app/01-building-your-application/03-data-fetching/03-revalidating.mdx
Show resolved
Hide resolved
My preferences (though I don't feel strongly). Reasons:
|
@delbaoliveira I updated everything according to your table and also added your table to the contribution guide. |
delbaoliveira
previously approved these changes
Jun 12, 2023
delbaoliveira
approved these changes
Jun 12, 2023
styfle
reviewed
Jun 12, 2023
docs/02-app/01-building-your-application/01-routing/05-dynamic-routes.mdx
Show resolved
Hide resolved
styfle
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we automate this with a lint rule?
Otherwise the mismatch will happen again in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was mismatched usage of
js
,jsx
,ts
, andtsx
. Just tried to get them all in sync.