Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes PORT from .env concatenation example #51063

Merged
merged 3 commits into from Jun 10, 2023

Conversation

manovotny
Copy link
Contributor

This is to avoid confusion about being able to set Next.js's port via .env, which is currently not allowed.

Comment on lines +60 to +61
TWITTER_USER=vercel
TWITTER_URL=https://twitter.com/$TWITTER_USER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TWITTER_USER=vercel
TWITTER_URL=https://twitter.com/$TWITTER_USER
TWITTER_USER=nextjs
TWITTER_URL=https://twitter.com/$TWITTER_USER

```

In the above example, `process.env.HOST` would be set to `http://localhost:8080`.
In the above example, `process.env.TWITTER_URL` would be set to `http://twitter.com/vercel`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the above example, `process.env.TWITTER_URL` would be set to `http://twitter.com/vercel`.
In the above example, `process.env.TWITTER_URL` would be set to `https://twitter.com/nextjs`.

@kodiakhq kodiakhq bot merged commit 8386009 into canary Jun 10, 2023
30 checks passed
@kodiakhq kodiakhq bot deleted the remove-port-from-env-example branch June 10, 2023 10:47
@manovotny manovotny mentioned this pull request Jun 14, 2023
kodiakhq bot pushed a commit that referenced this pull request Jun 14, 2023
Adds suggestions from #51063, which didn't get applied before merge.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants