Apply optimization to middleware when using babel #51067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
area: tests
created-by: Next.js team
ijjk
approved these changes
Jun 9, 2023
shuding
reviewed
Jun 9, 2023
| // This will cause some performance overhead but | ||
| // acceptable as Babel will not be recommended. | ||
| [ | ||
| getSwcLoader({ hasServerComponents: false, isServerLayer: false }), |
There was a problem hiding this comment.
Suggested change
| getSwcLoader({ hasServerComponents: false, isServerLayer: false }), | |
| getSwcLoader({ hasServerComponents: false }), |
isServerLayer: false is not necessary here.
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 10, 2023
This review comment was sent after merging the PR: #51067 (comment) The layer condition doesn't do anything if `hasServerComponents` is disabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like how we handled RSC loader transform before, we also apply swc loader to middleware to make sure the imports optimization is applied so og package won't be bundled
Fixes #50492