Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-icons: correct valid route segments for icon/favicon/apple-icon #51188

Merged
merged 1 commit into from Jun 12, 2023

Conversation

MaxLeiter
Copy link
Member

What?

Improves the documentation to correctly mention that only favicon is restricted to the root app/ segment.

x-ref: slack

@ijjk
Copy link
Member

ijjk commented Jun 12, 2023

Allow CI Workflow Run

  • approve CI run for commit: f7442ac

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leerob leerob merged commit cdfdaab into vercel:canary Jun 12, 2023
18 of 22 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants