Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved new line to warnOnce call #51552

Merged
merged 2 commits into from Jun 20, 2023
Merged

Moved new line to warnOnce call #51552

merged 2 commits into from Jun 20, 2023

Conversation

joshuabaker
Copy link
Contributor

What/Why

The console.log call was running per request and polluting logs.

Locally

$ next start
- ready started server on 0.0.0.0:3000, url: http://localhost:3000
- info Loaded env from /next/.env.local

- warn metadata.metadataBase is not set for resolving social open graph or twitter images, fallbacks to "http://localhost:3000". See https://nextjs.org/docs/app/api-reference/functions/generate-metadata#metadatabase














^C

Vercel

Screenshot 2023-06-20 at 12 08 56@2x

@vercel-spaces
Copy link

vercel-spaces bot commented Jun 20, 2023

Notifying the following users due to files changed in this PR:

@timneutkens, @ijjk, @shuding, @huozhi, @feedthejim:

packages/next/src/lib/metadata/resolvers/resolve-url.ts

This comment was posted based on the notify modifier.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@ijjk ijjk merged commit 2d2180f into vercel:canary Jun 20, 2023
33 of 34 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants