Skip to content

(example) update github-pages example #52168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 7, 2023
Merged

(example) update github-pages example #52168

merged 7 commits into from
Aug 7, 2023

Conversation

vinaykulk621
Copy link
Contributor

Removed appDir: true from experimental flag and code refactor.

@vinaykulk621 vinaykulk621 requested review from a team as code owners July 4, 2023 06:40
@vinaykulk621 vinaykulk621 requested review from manovotny and molebox July 4, 2023 06:40
@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 4, 2023
@ijjk
Copy link
Member

ijjk commented Jul 4, 2023

Allow CI Workflow Run

  • approve CI run for commit: e5742f2

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sorry, something went wrong.

1 similar comment
@ijjk
Copy link
Member

ijjk commented Jul 4, 2023

Allow CI Workflow Run

  • approve CI run for commit: e5742f2

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sorry, something went wrong.

@ijjk
Copy link
Member

ijjk commented Jul 4, 2023

Allow CI Workflow Run

  • approve CI run for commit: 34fa579

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sorry, something went wrong.

@manovotny
Copy link
Contributor

@vinaykulk621 thanks for the contribution! Any specific reason you're adding Inter to this example? If for no specific reason, let's remove it and get this merged.

@vinaykulk621
Copy link
Contributor Author

vinaykulk621 commented Jul 10, 2023

@manovotny
When you use create-next-app, it initializes the project with Inter out of the box.
I was trying to keep this example as close as possible to the create-next-app starter template.
Should i remove it?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vinaykulk621
Copy link
Contributor Author

@manovotny Any updates?

@styfle styfle added the CI approved Approve running CI for fork label Aug 7, 2023
@kodiakhq kodiakhq bot merged commit c669c38 into vercel:canary Aug 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants