fix metadata-related typo in MDX documentation #52446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs at https://nextjs.org/docs/pages/building-your-application/configuring/mdx currently advise you to set metadata manually by writing, for instance: ```typescript export const meta = { ``` But this does nothing, because in reality this should be "metadata": ```typescript export const metadata = { ``` according to this other documentation https://nextjs.org/docs/app/api-reference/functions/generate-metadata and my experience
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
@huozhi CI checks are failing at the "Set up runner" step with this error: I am unable to locate the source of this error in the codebase, find relevant instruction in any contributor guides, or otherwise diagnose it and figure out how to fix/merge. Could you please advise? |
|
@BrennanColberg it was CI flaky issue, fixed and merged 🙏 thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs at https://nextjs.org/docs/pages/building-your-application/configuring/mdx currently advise you to set metadata manually by writing, for instance:
But this does nothing, because in reality this should be "metadata":
according to this other documentation https://nextjs.org/docs/app/api-reference/functions/generate-metadata and my experience