Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/update with supabase demo deploy button #52483

Merged
merged 15 commits into from Sep 28, 2023
Merged

Chore/update with supabase demo deploy button #52483

merged 15 commits into from Sep 28, 2023

Conversation

MildTomato
Copy link
Contributor

What?

  • added correct deploy button urls
    • uses new supabase integration
  • updated readme for local development, more clearer instructions
  • added opengraph image

Why?

  • old supabase integration is buggy
  • readme is more clear for local development

@ijjk ijjk added the examples Issue/PR related to examples label Jul 10, 2023
@MildTomato MildTomato changed the title Chore/update woith supabase demo deploy button Chore/update with supabase demo deploy button Jul 10, 2023
@MildTomato
Copy link
Contributor Author

MildTomato commented Jul 10, 2023 •
edited

Also need @dijonmusters approval as he is the original contributor.

@thorwebdev thorwebdev mentioned this pull request Jul 10, 2023
Closed
dijonmusters
dijonmusters suggested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@dijonmusters dijonmusters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 🚀 Couple of small fixes

examples/with-supabase/README.md Outdated Show resolved Hide resolved
examples/with-supabase/README.md Outdated Show resolved Hide resolved
examples/with-supabase/README.md Outdated Show resolved Hide resolved
examples/with-supabase/README.md Outdated Show resolved Hide resolved
examples/with-supabase/README.md Outdated Show resolved Hide resolved
@MildTomato
Copy link
Contributor Author

@dijonmusters updated!

dijonmusters
dijonmusters approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@dijonmusters dijonmusters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Jonny! 🙌

@MildTomato
Copy link
Contributor Author

Wrong external-id used in deploy button. fixing

steven-tey
steven-tey previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@steven-tey steven-tey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🙏

@ijjk
Copy link
Member

ijjk commented Jul 17, 2023 •
edited by styfle

Allow CI Workflow Run

  • approve CI run for commit: 60f7685

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

leerob
leerob reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opengraph-image.png file should be in app/ and not public, right?

@MildTomato
Copy link
Contributor Author

sorry @leerob - only just seen this, moved to /app

balazsorban44
balazsorban44 previously approved these changes Aug 31, 2023
View reviewed changes
@ijjk ijjk requested a review from ztanner as a code owner September 28, 2023 00:23
@ijjk ijjk merged commit 06705a4 into vercel:canary Sep 28, 2023
53 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dijonmusters dijonmusters dijonmusters approved these changes

@balazsorban44 balazsorban44 balazsorban44 left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@styfle styfle Awaiting requested review from styfle styfle is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@manovotny manovotny Awaiting requested review from manovotny manovotny is a code owner automatically assigned from vercel/devex

@molebox molebox Awaiting requested review from molebox molebox is a code owner automatically assigned from vercel/devex

@steven-tey steven-tey Awaiting requested review from steven-tey

@leerob leerob Awaiting requested review from leerob

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

Assignees
No one assigned
Labels
examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MildTomato @ijjk @leerob @dijonmusters @balazsorban44 @steven-tey