Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not-found path doesn't include / derivate layout #52937

Closed
1 task done
sozonome opened this issue Jul 20, 2023 · 8 comments
Closed
1 task done

not-found path doesn't include / derivate layout #52937

sozonome opened this issue Jul 20, 2023 · 8 comments
Labels
bug Issue was opened via the bug report template. locked

Comments

@sozonome
Copy link

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 22.4.0: Mon Mar  6 20:59:28 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6000
    Binaries:
      Node: 16.14.0
      npm: 9.7.2
      Yarn: 1.22.19
      pnpm: 8.3.0
    Relevant Packages:
      next: 13.4.10
      eslint-config-next: 13.4.10
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.6
    Next.js Config:
      output: N/A

Which area(s) of Next.js are affected? (leave empty if unsure)

App Router

Link to the code that reproduces this issue or a replay of the bug

https://vercel.com/sozonome/nextjs-reproduce-not-found-issue

To Reproduce

Steps to Reproduce

  1. Install next v13.4.10 or later (including canary version)
  2. Add not-found.js/ts file
  3. Run next dev (also reproduced in build version)
  4. Open any pathname that are not defined (that should produce 404 / not-found error)

Actual Result

Will show 404 / not-found page, but doesn't include what's defined/composed in layout.js/ts

Expected Result

Will show 404 / not-found page and include what's defined/composed in layout.js/ts

Describe the Bug

app/not-found doesn't include layout since v13.4.10

not-found not include layout samples:

image

Expected Behavior

app/not-found include layout (it has been that way before v13.4.10, and there's no update in the documentation of next.js that says otherwise)

Screenshot 2023-07-20 at 19 40 32

Which browser are you using? (if relevant)

Brave v1.52.130

How are you deploying your application? (if relevant)

Vercel

@sozonome sozonome added the bug Issue was opened via the bug report template. label Jul 20, 2023
@huozhi
Copy link
Member

huozhi commented Jul 20, 2023

Fixed by #52790

@huozhi huozhi closed this as completed Jul 20, 2023
@sozonome
Copy link
Author

sozonome commented Jul 21, 2023

But the fix is reverted before release v13.4.11 ?
#52977

@ijjk ijjk reopened this Jul 21, 2023
@Galanthus
Copy link

Fixed by #52790

Sorry to say, but actually it's not fixed with the latest version.

@karlhorky
Copy link
Contributor

It looks like @huozhi re-landed the fix in #52985 (reviewed by @ijjk and published in next@13.4.12)

@Galanthus
Copy link

It looks like @huozhi re-landed the fix in #52985 (reviewed by @ijjk and published in next@13.4.12)

Having a custom not-fount.tsx/jsx won’t load id notFound is fired. This works fine in 13.4.9

@sozonome
Copy link
Author

I think it's already fixed in next@13.4.12

@Galanthus
Copy link

I think it's already fixed in next@13.4.12

that's what you Think.. but it is not. Easy closing?

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. locked
Projects
None yet
Development

No branches or pull requests

5 participants