Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove unnecessary effect dep #54134

Merged
merged 2 commits into from Aug 16, 2023
Merged

cleanup: remove unnecessary effect dep #54134

merged 2 commits into from Aug 16, 2023

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Aug 16, 2023

Accidentally left this in after making some changes in:

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 16, 2023
@ztanner ztanner marked this pull request as ready for review August 16, 2023 17:59
@kodiakhq kodiakhq bot merged commit 4f7fc05 into canary Aug 16, 2023
50 of 52 checks passed
@kodiakhq kodiakhq bot deleted the cleanup/remove-unnecessary-dep branch August 16, 2023 19:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ztanner @huozhi @ijjk