Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update template.js section #54370

Merged
merged 2 commits into from Aug 22, 2023
Merged

Docs: Update template.js section #54370

merged 2 commits into from Aug 22, 2023

Conversation

delbaoliveira
Copy link
Contributor

Fixes: https://vercel.slack.com/archives/C03S9JCH2Q5/p1692619927373449

  • Updates wording on nesting, to say it's not the actual output, but rather how template.js nests between layout.js and its children.
  • Remove mention of animations, needs further clarification.

@delbaoliveira delbaoliveira requested review from a team as code owners August 22, 2023 08:59
orca-security-us[bot]
orca-security-us bot reviewed Aug 22, 2023
View reviewed changes
Copy link

@orca-security-us orca-security-us bot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
passed Passed Secrets high 0  medium 0  low 0  info 0

@delbaoliveira delbaoliveira requested review from timneutkens and a team August 22, 2023 09:03
@kodiakhq kodiakhq bot merged commit f0ff3c4 into canary Aug 22, 2023
52 of 54 checks passed
@kodiakhq kodiakhq bot deleted the docs-f8e3 branch August 22, 2023 09:05
@github-actions github-actions bot added the locked label Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@orca-security-us orca-security-us[bot] orca-security-us left review comments

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan is a code owner automatically assigned from vercel/devex

@Nutlope Nutlope Awaiting requested review from Nutlope Nutlope is a code owner automatically assigned from vercel/devex

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js DevEx team locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delbaoliveira @timneutkens @ijjk