Client-side HMR message types #55009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
timneutkens
commented
Sep 5, 2023
| export default function initializeBuildWatcher( | ||
| toggleCallback: (cb: (obj: Record<string, any>) => void) => void, | ||
| toggleCallback: (handlers: ShowHideHandler) => void, |
There was a problem hiding this comment.
Changed this as previously it relied on building and built faked HMR events which wasn't needed, just a way to show/hide the building indicator.
timneutkens
commented
Sep 5, 2023
| if (pages.includes(router.query.__NEXT_PAGE)) { | ||
| return window.location.reload() | ||
| addMessageListener((payload) => { | ||
| if ('action' in payload) { |
There was a problem hiding this comment.
This is the same code as before, the diff is a bit messed up but had to split it by 'action' in payload in order to do type narrowing.
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
timneutkens
requested review from
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
huozhi
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Secrets | 0 1 0 0 |
View in Orca |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the previous PRs that introduce HMR event types for the server-side code, this leverages those types client-side too.