Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add maxDuration to PageConfig type #55918

Merged
merged 3 commits into from
Dec 1, 2023
Merged

fix: add maxDuration to PageConfig type #55918

merged 3 commits into from
Dec 1, 2023

Conversation

simonhaenisch
Copy link
Contributor

@simonhaenisch simonhaenisch commented Sep 24, 2023

Relevant docs: https://vercel.com/docs/functions/serverless-functions/runtimes#max-duration

Got an "action required" email about this, updated next, still got a type error on my config: PageConfig export.

The JSDoc description has been copied from the docs (slightly adjusted).

Fixes #55957.

@ijjk
Copy link
Member

ijjk commented Sep 24, 2023

Allow CI Workflow Run

  • approve CI run for commit: 617e539

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Sep 24, 2023

Allow CI Workflow Run

  • approve CI run for commit: 5ade1e0

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@simonhaenisch
Copy link
Contributor Author

simonhaenisch commented Nov 8, 2023

@ijjk it's been like 6 weeks with no attention for this PR (I already forgot I opened it), could you maybe at least approve this to run in the CI? It's only adding a single missing property to an interface.

@edwinbernadus
Copy link

need this PR
webstorm IDE show many errors from this condition

Copy link
Member

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxDuration is on top-level export, it's not part of the page config. We've already supported the type checking for this in nextjs typescript plugin

@simonhaenisch
Copy link
Contributor Author

hm weird apparently i didn't read properly (unless this was changed in the meantime 🤷🏻‍♂️)

@simonhaenisch simonhaenisch deleted the patch-2 branch December 1, 2023 09:13
@simonhaenisch simonhaenisch restored the patch-2 branch December 1, 2023 09:17
@simonhaenisch simonhaenisch reopened this Dec 1, 2023
@simonhaenisch
Copy link
Contributor Author

simonhaenisch commented Dec 1, 2023

@huozhi i didn't read wrong, if you switch in the docs to "Next.js (/pages)" (top right), you can see that when you're not using /app, you're supposed to set it via the config export which the PageConfig interface is for.

Screenshot 2023-12-01 at 10 25 40

Copy link
Member

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah right we need it for pages as well, thanks!

@huozhi huozhi added the CI approved Approve running CI for fork label Dec 1, 2023
@ijjk
Copy link
Member

ijjk commented Dec 1, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary simonhaenisch/next.js patch-2 Change
buildDuration 10.7s 10.7s N/A
buildDurationCached 6s 6.7s ⚠️ +674ms
nodeModulesSize 199 MB 199 MB ⚠️ +306 B
nextStartRea..uration (ms) 421ms 423ms N/A
Client Bundles (main, webpack)
vercel/next.js canary simonhaenisch/next.js patch-2 Change
199-HASH.js gzip 30.7 kB 30.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 240 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary simonhaenisch/next.js patch-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary simonhaenisch/next.js patch-2 Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary simonhaenisch/next.js patch-2 Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary simonhaenisch/next.js patch-2 Change
index.html gzip 528 B 528 B
link.html gzip 538 B 541 B N/A
withRouter.html gzip 523 B 523 B
Overall change 1.05 kB 1.05 kB
Edge SSR bundle Size
vercel/next.js canary simonhaenisch/next.js patch-2 Change
edge-ssr.js gzip 92.6 kB 92.6 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary simonhaenisch/next.js patch-2 Change
middleware-b..fest.js gzip 626 B 626 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 35.7 kB 35.7 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Next Runtimes
vercel/next.js canary simonhaenisch/next.js patch-2 Change
app-page-exp...dev.js gzip 168 kB 168 kB
app-page-exp..prod.js gzip 93.8 kB 93.8 kB
app-page-tur..prod.js gzip 94.5 kB 94.5 kB
app-page-tur..prod.js gzip 89.1 kB 89.1 kB
app-page.run...dev.js gzip 138 kB 138 kB
app-page.run..prod.js gzip 88.4 kB 88.4 kB
app-route-ex...dev.js gzip 24.2 kB 24.2 kB
app-route-ex..prod.js gzip 16.8 kB 16.8 kB
app-route-tu..prod.js gzip 16.9 kB 16.9 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route.ru...dev.js gzip 23.6 kB 23.6 kB
app-route.ru..prod.js gzip 16.4 kB 16.4 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.3 kB 49.3 kB
Overall change 930 kB 930 kB
Commit: 13fd666

@huozhi huozhi merged commit f476403 into vercel:canary Dec 1, 2023
62 of 67 checks passed
@simonhaenisch simonhaenisch deleted the patch-2 branch December 1, 2023 12:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maxDuration is missing in PageConfig
4 participants