Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use Response.json over NextResponse.json #56173

Merged
merged 2 commits into from Sep 28, 2023

Conversation

joulev
Copy link
Contributor

@joulev joulev commented Sep 28, 2023

TypeScript 5.2 now supports Response.json (microsoft/TypeScript#52841). That means, if we just need to return a JSON Response, we no longer need to import NextResponse. This PR updates all such instances in the documentation to use Response.json.

Signed-off-by: Vu Van Dung <me@joulev.dev>
@joulev joulev requested review from a team as code owners September 28, 2023 15:38
@joulev joulev requested review from leerob and molebox and removed request for a team September 28, 2023 15:38
@ijjk
Copy link
Member

ijjk commented Sep 28, 2023

Allow CI Workflow Run

  • approve CI run for commit: 875362d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@kodiakhq kodiakhq bot merged commit 7f6a494 into vercel:canary Sep 28, 2023
50 checks passed
@joulev joulev deleted the use-native-response-over-nextresponse branch September 29, 2023 01:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants