Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(fix): example text unescaped entities #57255

Merged
merged 2 commits into from Oct 27, 2023
Merged

docs(fix): example text unescaped entities #57255

merged 2 commits into from Oct 27, 2023

Conversation

Zoe-Bot
Copy link
Contributor

@Zoe-Bot Zoe-Bot commented Oct 23, 2023

Fix bug in example code. Loading with ' can not be built with the default ESLint rules:

./src/app/reviews/loading.tsx
4:15  Error: `'` can be escaped with `'`, `‘`, `'`, `’`.  react/no-unescaped-entities
4:26  Error: `'` can be escaped with `'`, `‘`, `'`, `’`.  react/no-unescaped-entities

@Zoe-Bot Zoe-Bot requested review from a team as code owners October 23, 2023 11:09
@Zoe-Bot Zoe-Bot requested review from ismaelrumzan and steven-tey and removed request for a team October 23, 2023 11:09
@kodiakhq kodiakhq bot merged commit f538232 into vercel:canary Oct 27, 2023
52 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan is a code owner automatically assigned from vercel/devex

@steven-tey steven-tey Awaiting requested review from steven-tey steven-tey is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zoe-Bot @leerob @ijjk