Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update @types/react version in examples #57259

Merged
merged 3 commits into from Oct 27, 2023

Conversation

HanCiHu
Copy link
Contributor

@HanCiHu HanCiHu commented Oct 23, 2023

What?

When I ran npx create-next-app --example with-turbopack and installed dependencies using yarn, I found an typescript error('SomeComponent' cannot be used as a JSX component.).

and I realized that the bug is due to the version of @types/react(18.0.x).
you can check this issue on here too.

Why?

It seems that there is an error occurring in the @types/react version 18.0.x.

How?

It would be good to change the @types/react version to 18.2.8 in the next.js examples.

I think this change will resolve this issue
NestJS documentation also states to upgrade the version.

@HanCiHu HanCiHu requested review from manovotny and delbaoliveira and removed request for a team October 23, 2023 12:46
@ijjk ijjk added the examples Issue/PR related to examples label Oct 23, 2023
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ijjk
Copy link
Member

ijjk commented Oct 27, 2023

Allow CI Workflow Run

  • approve CI run for commit: 02c2c0e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@leerob leerob merged commit 8d45aa9 into vercel:canary Oct 27, 2023
54 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
@HanCiHu HanCiHu deleted the update-@types/react-version-in-examples branch December 2, 2023 07:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript error with Next13, Monorepo (turbo repo), and Async components
3 participants