Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify tailwindcss related dependency of create-next-app #57262

Merged
merged 2 commits into from Oct 30, 2023

Conversation

moka-ayumu
Copy link
Contributor

What?

If the version of autoprefixer is 10.0.0 and the version of tailwindcss is less than 3.3.0, the error RangeError: Maximum call stack size exceeded occurs when you create with tailwindcss & typescript and run it.

Why?

The exact reason is unknown, but it appears to be a compatibility issue. Also, currently configuring tailwindcss with ts makes the tailwind config file in ts, which is supported since tailwindcss version 3.3.0. (In js, it works even if you set the version of autoprefixer to 10.0.1 and lower the version of tailwindcss.)

How?

Simply default the minimum version of autoprefixer to 10.0.1 and the minimum version of tailwindcss to 3.3.0.

@moka-ayumu moka-ayumu requested a review from a team as a code owner October 23, 2023 14:01
@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Oct 23, 2023
@moka-ayumu moka-ayumu force-pushed the fix/create-next-app-dependency branch from e05ebe3 to 0dffee9 Compare October 25, 2023 11:18
@moka-ayumu moka-ayumu requested a review from kdy1 October 26, 2023 09:50
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge for now (for the conf)

@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Allow CI Workflow Run

  • approve CI run for commit: f1383cc

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@moka-ayumu moka-ayumu force-pushed the fix/create-next-app-dependency branch from 0dffee9 to f1383cc Compare October 26, 2023 13:27
@moka-ayumu moka-ayumu force-pushed the fix/create-next-app-dependency branch from f1383cc to 81ce8a9 Compare October 30, 2023 13:18
@ijjk
Copy link
Member

ijjk commented Oct 30, 2023

Stats from current PR

Default Build
General
vercel/next.js canary moka-ayumu/next.js fix/create-next-app-dependency Change
buildDuration 10s 10.1s N/A
buildDurationCached 6s 5.8s N/A
nodeModulesSize 175 MB 175 MB
nextStartRea..uration (ms) 401ms 401ms
Client Bundles (main, webpack)
vercel/next.js canary moka-ayumu/next.js fix/create-next-app-dependency Change
199-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33.1 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary moka-ayumu/next.js fix/create-next-app-dependency Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary moka-ayumu/next.js fix/create-next-app-dependency Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary moka-ayumu/next.js fix/create-next-app-dependency Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary moka-ayumu/next.js fix/create-next-app-dependency Change
index.html gzip 529 B 529 B
link.html gzip 542 B 543 B N/A
withRouter.html gzip 524 B 525 B N/A
Overall change 529 B 529 B
Edge SSR bundle Size
vercel/next.js canary moka-ayumu/next.js fix/create-next-app-dependency Change
edge-ssr.js gzip 96.1 kB 96.1 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary moka-ayumu/next.js fix/create-next-app-dependency Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 23 kB 23 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 9177cb2

@kodiakhq kodiakhq bot merged commit 0623a4f into vercel:canary Oct 30, 2023
51 of 56 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants