Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Clarify built-in support for sass after installation #57279

Merged
merged 3 commits into from Oct 27, 2023
Merged

doc: Clarify built-in support for sass after installation #57279

merged 3 commits into from Oct 27, 2023

Conversation

JackHowa
Copy link
Contributor

@JackHowa JackHowa commented Oct 23, 2023 •
edited

  • Thanks for supporting sass. We were initially a little confused whether we needed to install it or whether it was built-in. Hope this little clarification helps others like us

@leerob leerob marked this pull request as ready for review October 27, 2023 00:18
@leerob leerob requested review from a team as code owners October 27, 2023 00:18
@leerob leerob requested review from manovotny and steven-tey and removed request for a team October 27, 2023 00:18
@ijjk
Copy link
Member

ijjk commented Oct 27, 2023 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: d681b73

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Oct 27, 2023 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: d681b73

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@leerob leerob merged commit 423e945 into vercel:canary Oct 27, 2023
53 checks passed
@JackHowa JackHowa deleted the patch-1 branch October 27, 2023 08:14
@JackHowa
Copy link
Contributor Author

thanks @leerob !

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@manovotny manovotny Awaiting requested review from manovotny manovotny is a code owner automatically assigned from vercel/devex

@steven-tey steven-tey Awaiting requested review from steven-tey steven-tey is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JackHowa @ijjk @leerob