update next/third-parties to use Next 14 or 13 as a peer dependency, instead of just 13

[philwolstenholme]

Just tried to update to 14 but next/third-parties looks like it's still expecting us to be on Next 13

Error: npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: shop-next@0.1.1
npm ERR! Found: next@14.0.0
npm ERR! node_modules/next
npm ERR!   next@"^14.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer next@"^13.0.0" from @next/third-parties@14.0.0
npm ERR! node_modules/@next/third-parties
npm ERR!   @next/third-parties@"^14.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/XXXXXXXX/.npm/_logs/2023-10-26T17_27_38_736Z-eresolve-report.txt

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 3c1415c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 286fbd8

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[ijjk]

Stats from current PR

Default Build

General

	vercel/next.js canary	philwolstenholme/next.js patch-2	Change
buildDuration	10.4s	10.6s	⚠️ +171ms
buildDurationCached	6.1s	5.9s	N/A
nodeModulesSize	175 MB	175 MB	✓
nextStartRea..uration (ms)	399ms	399ms	✓

Client Bundles (main, webpack)

	vercel/next.js canary	philwolstenholme/next.js patch-2	Change
199-HASH.js gzip	32.3 kB	32.3 kB	N/A
3f784ff6-HASH.js gzip	53.2 kB	53.2 kB	✓
99.HASH.js gzip	182 B	182 B	✓
framework-HASH.js gzip	45.5 kB	45.5 kB	✓
main-app-HASH.js gzip	254 B	252 B	N/A
main-HASH.js gzip	35.3 kB	35.3 kB	N/A
webpack-HASH.js gzip	1.75 kB	1.75 kB	N/A
Overall change	98.9 kB	98.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	philwolstenholme/next.js patch-2	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	philwolstenholme/next.js patch-2	Change
_app-HASH.js gzip	206 B	205 B	N/A
_error-HASH.js gzip	182 B	180 B	N/A
amp-HASH.js gzip	506 B	505 B	N/A
css-HASH.js gzip	322 B	323 B	N/A
dynamic-HASH.js gzip	2.59 kB	2.59 kB	✓
edge-ssr-HASH.js gzip	260 B	259 B	N/A
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	369 B	369 B	✓
image-HASH.js gzip	4.38 kB	4.38 kB	N/A
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	316 B	318 B	N/A
script-HASH.js gzip	385 B	384 B	N/A
withRouter-HASH.js gzip	319 B	319 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.99 kB	3.99 kB	✓

Client Build Manifests

	vercel/next.js canary	philwolstenholme/next.js patch-2	Change
_buildManifest.js gzip	484 B	482 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	philwolstenholme/next.js patch-2	Change
index.html gzip	528 B	531 B	N/A
link.html gzip	541 B	543 B	N/A
withRouter.html gzip	524 B	526 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	philwolstenholme/next.js patch-2	Change
edge-ssr.js gzip	96 kB	96 kB	N/A
page.js gzip	140 kB	140 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	philwolstenholme/next.js patch-2	Change
middleware-b..fest.js gzip	623 B	623 B	✓
middleware-r..fest.js gzip	150 B	151 B	N/A
middleware.js gzip	25.8 kB	25.8 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	2.55 kB	2.55 kB	✓

Commit: 89757b2

[nickmccurdy]

It seems like this has only been released in the canary channel, therefore if you follow the documentation this still errors by default.

[saurabhsri108]

This is still giving an error during installation.

[philwolstenholme]

Yes, you'll need to either use a canary release or wait until the next patch release. It shouldn't be too long.

Alternatively you can tell npm to ignore peer dependencies (https://stackoverflow.com/a/69429293), or use https://www.npmjs.com/package/patch-package to patch the package.json file.