Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traces] Await the flush of the trace write stream to make sure trace file is written #57641

Merged
merged 3 commits into from Oct 27, 2023

Conversation

mknichel
Copy link
Member

This PR fixes an issue where sometimes the .next/trace file would not be written at the end of a build. The process was not waiting for the write stream to be flushed before closing, losing the contents of the trace, which was especially visible when using experimental-compile.

@ijjk
Copy link
Member

ijjk commented Oct 27, 2023

Allow CI Workflow Run

  • approve CI run for commit: ca5fd68

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Oct 27, 2023

Allow CI Workflow Run

  • approve CI run for commit: ca5fd68

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk ijjk added the CI approved Approve running CI for fork label Oct 27, 2023
@ijjk
Copy link
Member

ijjk commented Oct 27, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js mknichel/next-trace-webpack-build-worker Change
buildDuration 10.6s 10.6s N/A
buildDurationCached 6s 6s N/A
nodeModulesSize 175 MB 175 MB N/A
nextStartRea..uration (ms) 413ms 420ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mknichel/next-trace-webpack-build-worker Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mknichel/next-trace-webpack-build-worker Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js mknichel/next-trace-webpack-build-worker Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js mknichel/next-trace-webpack-build-worker Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js mknichel/next-trace-webpack-build-worker Change
index.html gzip 529 B 530 B N/A
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 525 B N/A
Overall change 542 B 542 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mknichel/next-trace-webpack-build-worker Change
edge-ssr.js gzip 96.1 kB 96.1 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js mknichel/next-trace-webpack-build-worker Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.8 kB 25.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 90135fb

@ijjk
Copy link
Member

ijjk commented Oct 27, 2023

Tests Passed

@kodiakhq kodiakhq bot merged commit ec20e24 into canary Oct 27, 2023
53 of 58 checks passed
@kodiakhq kodiakhq bot deleted the mknichel/next-trace-webpack-build-worker branch October 27, 2023 22:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants