Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Build compilation warning when using middleware #57685

Merged
merged 5 commits into from Oct 30, 2023

Conversation

Nayeem-XTREME
Copy link
Contributor

Fixing a bug

What?

If there is a middleware.js or middleware.ts file in Next.JS 14, running next build shows the following warning:

./node_modules/next/dist/esm/shared/lib/router/utils/app-paths.js
A Node.js module is loaded ('url' at line 3) which is not supported in the Edge Runtime.
Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime

Import trace for requested module:
./node_modules/next/dist/esm/shared/lib/router/utils/app-paths.js

This PR will remove the warning.

Closes NEXT-
Fixes #57533

@huozhi huozhi added the CI approved Approve running CI for fork label Oct 30, 2023
@ijjk
Copy link
Member

ijjk commented Oct 30, 2023

Stats from current PR

Default Build
General
vercel/next.js canary Nayeem-XTREME/next.js nayeemxtreme/fix-middleware Change
buildDuration 10.5s 10.5s N/A
buildDurationCached 6.1s 6.1s N/A
nodeModulesSize 175 MB 175 MB N/A
nextStartRea..uration (ms) 400ms 396ms N/A
Client Bundles (main, webpack)
vercel/next.js canary Nayeem-XTREME/next.js nayeemxtreme/fix-middleware Change
199-HASH.js gzip 32.3 kB N/A N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 35.3 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
513-HASH.js gzip N/A 30 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Nayeem-XTREME/next.js nayeemxtreme/fix-middleware Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Nayeem-XTREME/next.js nayeemxtreme/fix-middleware Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary Nayeem-XTREME/next.js nayeemxtreme/fix-middleware Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary Nayeem-XTREME/next.js nayeemxtreme/fix-middleware Change
index.html gzip 529 B 529 B
link.html gzip 543 B 541 B N/A
withRouter.html gzip 524 B 524 B
Overall change 1.05 kB 1.05 kB
Edge SSR bundle Size
vercel/next.js canary Nayeem-XTREME/next.js nayeemxtreme/fix-middleware Change
edge-ssr.js gzip 96.1 kB 96.1 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary Nayeem-XTREME/next.js nayeemxtreme/fix-middleware Change
middleware-b..fest.js gzip 625 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.8 kB 23 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 199-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: ba5b784

@kodiakhq kodiakhq bot merged commit 3248ee7 into vercel:canary Oct 30, 2023
57 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build compilation warning "Node.js module is loaded ('url' at line 3)" when using middleware
3 participants