Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React from 8c8ee9ee6 to 0c6348758 and types #57772

Merged
merged 2 commits into from Oct 30, 2023
Merged

Update React from 8c8ee9ee6 to 0c6348758 and types #57772

merged 2 commits into from Oct 30, 2023

Conversation

gnoff
Copy link
Contributor

@gnoff gnoff commented Oct 30, 2023

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 30, 2023
feedthejim
feedthejim previously approved these changes Oct 30, 2023
View reviewed changes
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
scheduler 0.0.0-experimental-8c8ee9ee6-20231026...0.0.0-experimental-0c6348758-20231030, 0.24.0-canary-8c8ee9ee6-20231026...0.0.0-experimental-0c6348758-20231030 None +0/-0 117 kB
scheduler 0.0.0-experimental-8c8ee9ee6-20231026...0.24.0-canary-0c6348758-20231030, 0.24.0-canary-8c8ee9ee6-20231026...0.24.0-canary-0c6348758-20231030 None +0/-0 117 kB
react 0.0.0-experimental-8c8ee9ee6-20231026...18.3.0-canary-0c6348758-20231030, 18.3.0-canary-8c8ee9ee6-20231026...18.3.0-canary-0c6348758-20231030 None +0/-0 405 kB
react 0.0.0-experimental-8c8ee9ee6-20231026...0.0.0-experimental-0c6348758-20231030, 18.3.0-canary-8c8ee9ee6-20231026...0.0.0-experimental-0c6348758-20231030 None +0/-0 433 kB
react-dom 0.0.0-experimental-8c8ee9ee6-20231026...0.0.0-experimental-0c6348758-20231030, 18.3.0-canary-8c8ee9ee6-20231026...0.0.0-experimental-0c6348758-20231030 None +5/-0 10.4 MB
react-dom 0.0.0-experimental-8c8ee9ee6-20231026...18.3.0-canary-0c6348758-20231030, 18.3.0-canary-8c8ee9ee6-20231026...18.3.0-canary-0c6348758-20231030 None +5/-10 8.6 MB

@ijjk
Copy link
Member

ijjk commented Oct 30, 2023 •
edited

Stats from current PR

Default Build
General
vercel/next.js canary gnoff/next.js update-react Change
buildDuration 10.2s 10.4s ⚠️ +128ms
buildDurationCached 5.8s 6.1s ⚠️ +315ms
nodeModulesSize 175 MB 175 MB N/A
nextStartRea..uration (ms) 412ms 419ms N/A
Client Bundles (main, webpack)
vercel/next.js canary gnoff/next.js update-react Change
199-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B ✓
framework-HASH.js gzip 45.5 kB 45.5 kB ✓
main-app-HASH.js gzip 254 B 250 B N/A
main-HASH.js gzip 33.1 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary gnoff/next.js update-react Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary gnoff/next.js update-react Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB ✓
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.99 kB 3.99 kB ✓
Client Build Manifests
vercel/next.js canary gnoff/next.js update-react Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary gnoff/next.js update-react Change
index.html gzip 529 B 529 B ✓
link.html gzip 542 B 543 B N/A
withRouter.html gzip 524 B 525 B N/A
Overall change 529 B 529 B ✓
Edge SSR bundle Size
vercel/next.js canary gnoff/next.js update-react Change
edge-ssr.js gzip 96.1 kB 96.1 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary gnoff/next.js update-react Change
middleware-b..fest.js gzip 623 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 23 kB 23 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Commit: 45d7576

@gnoff
Update @types/react and @types/react-dom
45d7576 
Update @types/react to 18.2.33
Update @types/react-dom to 18.2.14
@ijjk ijjk merged commit e26c901 into vercel:canary Oct 30, 2023
52 of 57 checks passed
@gnoff gnoff deleted the update-react branch October 30, 2023 18:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk ijjk approved these changes

@feedthejim feedthejim feedthejim left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gnoff @ijjk @huozhi @feedthejim