Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix grammar in Caching section #58070

Merged
merged 2 commits into from
Nov 17, 2023
Merged

docs: Fix grammar in Caching section #58070

merged 2 commits into from
Nov 17, 2023

Conversation

kentobento
Copy link
Contributor

This PR fixes several grammar issues in https://nextjs.org/docs/app/building-your-application/caching.

@kentobento kentobento requested review from a team as code owners November 6, 2023 02:42
@kentobento kentobento requested review from ismaelrumzan and StephDietz and removed request for a team November 6, 2023 02:42
@leerob
Copy link
Member

leerob commented Nov 16, 2023

Merge conflicts

@ijjk
Copy link
Member

ijjk commented Nov 16, 2023 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: 6428d64

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 16, 2023 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: e3a0d90

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@kentobento kentobento marked this pull request as draft November 16, 2023 06:58
@kentobento kentobento force-pushed the kent--docs-pt-3 branch 4 times, most recently from fdd7bd6 to 4fb2cc3 Compare November 16, 2023 07:07
@kentobento kentobento marked this pull request as ready for review November 16, 2023 07:08
@leerob leerob merged commit 7d2be4b into vercel:canary Nov 17, 2023
52 of 54 checks passed
@github-actions github-actions bot added the locked label Dec 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan is a code owner automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kentobento @leerob @ijjk