Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples): add upload file example with Server Actions #58467

Merged
merged 6 commits into from
Nov 17, 2023
Merged

feat(examples): add upload file example with Server Actions #58467

merged 6 commits into from
Nov 17, 2023

Conversation

suhaotian
Copy link
Contributor

Add upload file example with Server Actions

@suhaotian suhaotian requested review from a team as code owners November 15, 2023 04:56
@suhaotian suhaotian requested review from S3Prototype and StephDietz and removed request for a team November 15, 2023 04:56
@ijjk ijjk added the examples Issue/PR related to examples label Nov 15, 2023
@ijjk
Copy link
Member

ijjk commented Nov 15, 2023 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: a96c50a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk
Copy link
Member

ijjk commented Nov 15, 2023 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: a96c50a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 15, 2023 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: a96c50a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 15, 2023 •
edited by leerob

Allow CI Workflow Run

  • approve CI run for commit: 26f1560

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

leerob
leerob reviewed Nov 16, 2023
View reviewed changes
examples/server-actions-upload/README.md Outdated Show resolved Hide resolved
examples/server-actions-upload/package.json Outdated Show resolved Hide resolved
examples/server-actions-upload/app/action.ts Outdated Show resolved Hide resolved
leerob
leerob requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend removing everything non-essential. Seems like you can remove Tailwind (not really used) and the files in public/.

@suhaotian
Copy link
Contributor Author

I'd recommend removing everything non-essential. Seems like you can remove Tailwind (not really used) and the files in public/.

Done! Thanks!

@kodiakhq kodiakhq bot merged commit 2e85806 into vercel:canary Nov 17, 2023
55 checks passed
@github-actions github-actions bot added the locked label Dec 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@S3Prototype S3Prototype Awaiting requested review from S3Prototype S3Prototype is a code owner automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suhaotian @ijjk @leerob