Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates with-supertokens example app #58525

Merged
merged 12 commits into from
Dec 4, 2023
Merged

Updates with-supertokens example app #58525

merged 12 commits into from
Dec 4, 2023

Conversation

rishabhpoddar
Copy link
Contributor

Change with-supertokens example app to use app dir.

@rishabhpoddar rishabhpoddar requested review from ismaelrumzan and lydiahallie and removed request for a team November 16, 2023 05:58
@ijjk ijjk added the examples Issue/PR related to examples label Nov 16, 2023
leerob
leerob previously approved these changes Nov 16, 2023
@leerob
Copy link
Member

leerob commented Nov 16, 2023

/root/actions-runner/_work/next.js/next.js/examples/with-supertokens/app/api/user/route.ts
  3:8  warning  'SuperTokens' is defined but never used  @typescript-eslint/no-unused-vars

/root/actions-runner/_work/next.js/next.js/examples/with-supertokens/app/components/tryRefreshClientComponent.tsx
   4:21  warning  'redirect' is defined but never used                                                                       @typescript-eslint/no-unused-vars
  24:6   warning  React Hook useEffect has a missing dependency: 'router'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

✖ 3 problems (0 errors, 3 warnings)

@rishabhpoddar
Copy link
Contributor Author

@leerob thanks for pointing those issues out. I have pushed a fix.

@leerob
Copy link
Member

leerob commented Nov 17, 2023

Now needs Prettier ran...

@rishabhpoddar
Copy link
Contributor Author

I had run pnpm lint-fix && pnpm prettier-fix and there were no file changes. Plus the pre commit hook passed all checks. Is there another command I missed?

@rishabhpoddar
Copy link
Contributor Author

Any updates on this please? Thanks.

@rishabhpoddar
Copy link
Contributor Author

I ran ./scripts/check-examples.sh and it made a change to the package.json in the example app (which is what was causing the PR check to fail previously). Is this good to be merged now?

@leerob leerob merged commit 484efae into vercel:canary Dec 4, 2023
31 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants