-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove early return that is duplicated in useSearchParams #58545
Merged
kodiakhq
merged 2 commits into
canary
from
11-16-Remove_early_return_that_is_duplicated_in_useSearchParams
Nov 16, 2023
Merged
Remove early return that is duplicated in useSearchParams #58545
kodiakhq
merged 2 commits into
canary
from
11-16-Remove_early_return_that_is_duplicated_in_useSearchParams
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
November 16, 2023 17:53
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
Diff detailsDiff for page.jsDiff too large to display Diff for app-page-exp..ntime.dev.jsDiff too large to display Diff for app-page.runtime.dev.jsDiff too large to display |
ztanner
approved these changes
Nov 16, 2023
…ed_in_useSearchParams
Tests Passed |
kodiakhq
bot
deleted the
11-16-Remove_early_return_that_is_duplicated_in_useSearchParams
branch
November 16, 2023 19:35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Noticed that the return is the same, so we don't have to add this specific return.