Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-toolchain to 2023-11-16 #58558

Merged
merged 11 commits into from
Nov 18, 2023
Merged

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Nov 17, 2023

This updates the rust toolchain to 2023-11-16 and:

  • Removes now-unnecessary #![feature(async_fn_in_trait)]
  • Applies auto-fixable lint fixes
  • Uses Cargo.toml new lint section instead of command line rustc flags

Test Plan: Tested with updated turbo in a create-next-app

Closes PACK-1979

This updates the rust toolchain to 2023-11-16 and:

- Removes now-unnecessary `#![feature(async_fn_in_trait)]`
- Applies auto-fixable lint fixes
- Uses `Cargo.toml` new `lint` section instead of command line rustc flags

Test Plan: Tested with updated turbo in a create-next-app
@ijjk ijjk added Font (next/font) Related to Next.js Font Optimization. Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Nov 17, 2023
@ijjk
Copy link
Member

ijjk commented Nov 17, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Nov 17, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js wbinnssmith/rust-nightly-2023-11-16 Change
buildDuration 10.3s 10.4s ⚠️ +122ms
buildDurationCached 5.9s 6.7s ⚠️ +730ms
nodeModulesSize 199 MB 199 MB
nextStartRea..uration (ms) 425ms 416ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js wbinnssmith/rust-nightly-2023-11-16 Change
199-HASH.js gzip 28.8 kB 28.8 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js wbinnssmith/rust-nightly-2023-11-16 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js wbinnssmith/rust-nightly-2023-11-16 Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 504 B 506 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.3 kB 4.3 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.63 kB 2.63 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js wbinnssmith/rust-nightly-2023-11-16 Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js wbinnssmith/rust-nightly-2023-11-16 Change
index.html gzip 529 B 528 B N/A
link.html gzip 539 B 541 B N/A
withRouter.html gzip 523 B 523 B
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js wbinnssmith/rust-nightly-2023-11-16 Change
edge-ssr.js gzip 92.6 kB 92.6 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js wbinnssmith/rust-nightly-2023-11-16 Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Next Runtimes
vercel/next.js canary vercel/next.js wbinnssmith/rust-nightly-2023-11-16 Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.4 kB 93.4 kB
app-page-tur..prod.js gzip 94.1 kB 94.1 kB
app-page-tur..prod.js gzip 88.7 kB 88.7 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 88 kB 88 kB
app-route-ex...dev.js gzip 23.8 kB 23.8 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.5 kB 16.5 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 23.2 kB 23.2 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 49.1 kB 49.1 kB
Overall change 924 kB 924 kB
Commit: 1dee923

kdy1
kdy1 previously approved these changes Nov 17, 2023
sokra
sokra previously approved these changes Nov 17, 2023
@sokra sokra marked this pull request as draft November 17, 2023 06:52
@wbinnssmith wbinnssmith marked this pull request as ready for review November 17, 2023 22:16
@kodiakhq kodiakhq bot merged commit 024a0ef into canary Nov 18, 2023
60 checks passed
@kodiakhq kodiakhq bot deleted the wbinnssmith/rust-nightly-2023-11-16 branch November 18, 2023 00:29
@github-actions github-actions bot added the locked label Dec 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team Font (next/font) Related to Next.js Font Optimization. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants