Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.next/trace] Track server requests and memory usage #58690

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

mknichel
Copy link
Member

@mknichel mknichel commented Nov 20, 2023

This PR adds more information to .next/trace for local development:

  • Break down server startup times into setting up the dev bundler and running the instrumentation hook
  • Add top level span for handling a request such as a page request, app router request, or API request
  • Add span for compilation time tracking the path of the route that triggered the compilation.
  • Track memory usage after every request
  • Track event when server is restarted due to reaching the memory limit

Platform stats and memory usage on startup:
Screenshot 2023-11-20 at 8 47 38 AM

Memory usage after each request:
Screenshot 2023-11-20 at 9 16 44 AM

Split server startup times into setting up the dev bundler and running the instrumentation hook:
Screenshot 2023-11-20 at 8 46 41 AM

@ijjk
Copy link
Member

ijjk commented Nov 20, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js mknichel/next-trace-page-requests-memory-usage Change
buildDuration 10.4s 10.4s N/A
buildDurationCached 6s 5.8s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +19.9 kB
nextStartRea..uration (ms) 417ms 425ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mknichel/next-trace-page-requests-memory-usage Change
199-HASH.js gzip 28.7 kB 28.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mknichel/next-trace-page-requests-memory-usage Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js mknichel/next-trace-page-requests-memory-usage Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.28 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js mknichel/next-trace-page-requests-memory-usage Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js mknichel/next-trace-page-requests-memory-usage Change
index.html gzip 527 B 526 B N/A
link.html gzip 539 B 540 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mknichel/next-trace-page-requests-memory-usage Change
edge-ssr.js gzip 92.4 kB 92.4 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js mknichel/next-trace-page-requests-memory-usage Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 27.4 kB 27.4 kB
Next Runtimes
vercel/next.js canary vercel/next.js mknichel/next-trace-page-requests-memory-usage Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.3 kB 93.3 kB
app-page-tur..prod.js gzip 94 kB 94 kB
app-page-tur..prod.js gzip 88.6 kB 88.6 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 87.9 kB 87.9 kB
app-route-ex...dev.js gzip 23.8 kB 23.8 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.5 kB 16.5 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 23.2 kB 23.2 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 49.1 kB 49.1 kB
Overall change 924 kB 924 kB
Commit: fb6855a

@mknichel mknichel marked this pull request as ready for review November 20, 2023 20:45
@ijjk
Copy link
Member

ijjk commented Nov 22, 2023

Tests Passed

@kodiakhq kodiakhq bot merged commit 3aa62d1 into canary Nov 22, 2023
55 of 60 checks passed
@kodiakhq kodiakhq bot deleted the mknichel/next-trace-page-requests-memory-usage branch November 22, 2023 22:25
@github-actions github-actions bot added the locked label Dec 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants