-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix: fetch() behavior when "dynamic" is "force-dynamic" #58735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ba3ef55.
ijjk
added
area: tests
created-by: Next.js team
PRs by the Next.js team
type: next
labels
Nov 21, 2023
ztanner
force-pushed
the
revert-58484-fix-force-dynamic
branch
from
November 21, 2023 15:41
7fa8f7f
to
48ed975
Compare
ztanner
force-pushed
the
revert-58484-fix-force-dynamic
branch
from
November 21, 2023 15:41
48ed975
to
e2867ec
Compare
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
Diff detailsDiff for page.jsDiff too large to display Diff for app-route-ex..ntime.dev.jsDiff too large to display Diff for app-route-ex..time.prod.jsDiff too large to display Diff for app-route-tu..time.prod.jsDiff too large to display Diff for app-route-tu..time.prod.jsDiff too large to display Diff for app-route.runtime.dev.jsDiff too large to display Diff for app-route.ru..time.prod.jsDiff too large to display |
ztanner
requested review from
a team,
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim and
wyattjoh
as code owners
November 21, 2023 16:19
ztanner
requested review from
ismaelrumzan and
lydiahallie
and removed request for
a team
November 21, 2023 16:19
ijjk
previously approved these changes
Nov 21, 2023
Tests Passed |
ijjk
approved these changes
Nov 22, 2023
feedthejim
approved these changes
Nov 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #58484
The correct way to address this is to use the
fetchCache
segment: https://nextjs.org/docs/app/api-reference/file-conventions/route-segment-config#fetchcacheThere are valid use-cases to want to force a dynamic response but still need fetch caching.
Additionally, this PR updates the docs, since they're incorrect about behavior.
slack x-ref