-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route handlers: make req.cookies opt you into dynamic #58769
Merged
kodiakhq
merged 3 commits into
canary
from
feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers
Nov 22, 2023
Merged
route handlers: make req.cookies opt you into dynamic #58769
kodiakhq
merged 3 commits into
canary
from
feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedthejim
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
ztanner and
wyattjoh
as code owners
November 22, 2023 12:57
ijjk
added
area: tests
created-by: Next.js team
PRs by the Next.js team
type: next
labels
Nov 22, 2023
timneutkens
approved these changes
Nov 22, 2023
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | vercel/next.js feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers | Change | |
---|---|---|---|
buildDuration | 10.3s | 10.7s | |
buildDurationCached | 5.9s | 6.5s | |
nodeModulesSize | 199 MB | 199 MB | |
nextStartRea..uration (ms) | 431ms | 426ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers | Change | |
---|---|---|---|
199-HASH.js gzip | 28.7 kB | 28.7 kB | N/A |
3f784ff6-HASH.js gzip | 53.3 kB | 53.3 kB | ✓ |
494.HASH.js gzip | 180 B | 181 B | N/A |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 241 B | 239 B | N/A |
main-HASH.js gzip | 31.7 kB | 31.7 kB | N/A |
webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
Overall change | 100 kB | 100 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers | Change | |
---|---|---|---|
_app-HASH.js gzip | 194 B | 195 B | N/A |
_error-HASH.js gzip | 182 B | 181 B | N/A |
amp-HASH.js gzip | 501 B | 503 B | N/A |
css-HASH.js gzip | 322 B | 323 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | ✓ |
edge-ssr-HASH.js gzip | 253 B | 255 B | N/A |
head-HASH.js gzip | 348 B | 347 B | N/A |
hooks-HASH.js gzip | 369 B | 368 B | N/A |
image-HASH.js gzip | 4.28 kB | 4.27 kB | N/A |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.61 kB | 2.6 kB | N/A |
routerDirect..HASH.js gzip | 311 B | 311 B | ✓ |
script-HASH.js gzip | 384 B | 383 B | N/A |
withRouter-HASH.js gzip | 307 B | 308 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.17 kB | 3.17 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers | Change | |
---|---|---|---|
_buildManifest.js gzip | 484 B | 483 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers | Change | |
---|---|---|---|
index.html gzip | 527 B | 526 B | N/A |
link.html gzip | 539 B | 540 B | N/A |
withRouter.html gzip | 524 B | 521 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers | Change | |
---|---|---|---|
edge-ssr.js gzip | 92.4 kB | 92.4 kB | N/A |
page.js gzip | 145 kB | 145 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 624 B | 625 B | N/A |
middleware-r..fest.js gzip | 150 B | 151 B | N/A |
middleware.js gzip | 24.8 kB | 24.8 kB | N/A |
edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
Overall change | 1.92 kB | 1.92 kB | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 167 kB | 167 kB | ✓ |
app-page-exp..prod.js gzip | 93.3 kB | 93.3 kB | ✓ |
app-page-tur..prod.js gzip | 94 kB | 94 kB | ✓ |
app-page-tur..prod.js gzip | 88.6 kB | 88.6 kB | ✓ |
app-page.run...dev.js gzip | 137 kB | 137 kB | ✓ |
app-page.run..prod.js gzip | 87.9 kB | 87.9 kB | ✓ |
app-route-ex...dev.js gzip | 23.8 kB | 23.8 kB | N/A |
app-route-ex..prod.js gzip | 16.4 kB | 16.5 kB | N/A |
app-route-tu..prod.js gzip | 16.5 kB | 16.5 kB | N/A |
app-route-tu..prod.js gzip | 16 kB | 16 kB | N/A |
app-route.ru...dev.js gzip | 23.2 kB | 23.2 kB | N/A |
app-route.ru..prod.js gzip | 16 kB | 16 kB | N/A |
pages-api-tu..prod.js gzip | 9.37 kB | 9.37 kB | ✓ |
pages-api.ru...dev.js gzip | 9.64 kB | 9.64 kB | ✓ |
pages-api.ru..prod.js gzip | 9.37 kB | 9.37 kB | ✓ |
pages-turbo...prod.js gzip | 21.8 kB | 21.8 kB | ✓ |
pages.runtim...dev.js gzip | 22.5 kB | 22.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.8 kB | 21.8 kB | ✓ |
server.runti..prod.js gzip | 49.1 kB | 49.1 kB | ✓ |
Overall change | 812 kB | 812 kB | ✓ |
Diff details
Diff for app-route-ex..ntime.dev.js
Diff too large to display
Diff for app-route-ex..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route.runtime.dev.js
Diff too large to display
Diff for app-route.ru..time.prod.js
Diff too large to display
leerob
approved these changes
Nov 22, 2023
…-you-out-from-statiic-in-route-handlers
kodiakhq
bot
deleted the
feedthejim/next-1727-reqcookies-doesnt-opt-you-out-from-statiic-in-route-handlers
branch
November 22, 2023 14:29
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where users would try to access
req.cookies
from a route handler and be unable to read from it.This issue was caused by
req.cookies
not opting you into dynamic behaviour, unlikecookies()
fromnext/headers
. This fixes it.