Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry: propagate context to sandbox #58791

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

dvoytenko
Copy link
Member

The sandboxed request processing do not share the same async context with the BaseServer and thus the context should be propagated independently.

Notably, the headers API is different in BaseServer (Record<string, string | string[]>) vs in the sandbox (Headers), so additionally, we have to use the right getter.

@ijjk
Copy link
Member

ijjk commented Nov 22, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Nov 22, 2023

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary dvoytenko/next.js otel-propagation-worker Change
buildDuration 10.1s 10.3s ⚠️ +130ms
buildDurationCached 5.8s 6.5s ⚠️ +735ms
nodeModulesSize 199 MB 199 MB ⚠️ +2.85 kB
nextStartRea..uration (ms) 424ms 419ms N/A
Client Bundles (main, webpack)
vercel/next.js canary dvoytenko/next.js otel-propagation-worker Change
199-HASH.js gzip 28.7 kB 28.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary dvoytenko/next.js otel-propagation-worker Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary dvoytenko/next.js otel-propagation-worker Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.28 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary dvoytenko/next.js otel-propagation-worker Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary dvoytenko/next.js otel-propagation-worker Change
index.html gzip 528 B 527 B N/A
link.html gzip 538 B 543 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary dvoytenko/next.js otel-propagation-worker Change
edge-ssr.js gzip 92.4 kB 92.4 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size Overall increase ⚠️
vercel/next.js canary dvoytenko/next.js otel-propagation-worker Change
middleware-b..fest.js gzip 626 B 626 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 35.6 kB ⚠️ +10.8 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 27.4 kB 38.2 kB ⚠️ +10.8 kB
Next Runtimes
vercel/next.js canary dvoytenko/next.js otel-propagation-worker Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.3 kB 93.3 kB
app-page-tur..prod.js gzip 94.1 kB 94.1 kB
app-page-tur..prod.js gzip 88.6 kB 88.6 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 88 kB 88 kB
app-route-ex...dev.js gzip 23.8 kB 23.8 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.5 kB 16.5 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 23.2 kB 23.2 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 49.1 kB 49.1 kB N/A
Overall change 875 kB 875 kB
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 9a217c1

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the resolving for edge is missing @opentelemetry/api in https://github.com/vercel/next.js/blob/0cb1c404005de79b8cfbf3eac97e90616d5d4f45/packages/next-swc/crates/next-core/src/next_import_map.rs.

Will ask the Turbopack team to take a look

@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner November 24, 2023 14:16
@kodiakhq kodiakhq bot merged commit b8a18f6 into vercel:canary Nov 24, 2023
57 of 58 checks passed
@timneutkens
Copy link
Member

Thanks Leah!

@dvoytenko dvoytenko deleted the otel-propagation-worker branch November 24, 2023 17:36
@github-actions github-actions bot added the locked label Dec 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants