Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add direct link to Dockerfile #58793

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

LukeSchlangen
Copy link
Contributor

For Contributors

Improving Documentation

It may not be clear to users directly viewing the with-docker README where the Dockerfile is to be copied. This direct link makes it easier to find.

@LukeSchlangen LukeSchlangen requested review from a team as code owners November 22, 2023 20:14
@LukeSchlangen LukeSchlangen requested review from timeyoutakeit and leerob and removed request for a team November 22, 2023 20:14
@ijjk ijjk added the examples Issue/PR related to examples label Nov 22, 2023
@ijjk
Copy link
Member

ijjk commented Nov 28, 2023

Allow CI Workflow Run

  • approve CI run for commit: 95b4966

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk
Copy link
Member

ijjk commented Nov 28, 2023

Allow CI Workflow Run

  • approve CI run for commit: 95b4966

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 28, 2023

Allow CI Workflow Run

  • approve CI run for commit: 95b4966

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@leerob leerob merged commit 92f7d0c into vercel:canary Nov 30, 2023
22 of 29 checks passed
@LukeSchlangen LukeSchlangen deleted the add-dockerfile-link branch November 30, 2023 02:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants