Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rewrites to edge routes #58797

Merged
merged 3 commits into from
Nov 23, 2023
Merged

fix rewrites to edge routes #58797

merged 3 commits into from
Nov 23, 2023

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Nov 22, 2023

What?

Rewrites to an edge route currently throw an invariant rather than properly serving up the page that is rewritten to.

Why?

The NextRequest object that is provided to the edge route handler contains pathname information only for the "origin" request (e.g., when visiting /one/example which rewrites to /two/example, the pathname is still /one/example. This hits an invariant since the route matcher is unable to find /one/example since it does not exist.

How?

This updates the module wrapper to grab the pathname from the route definition rather than the request object. For dynamic segments, we extract them from request.nextUrl since we know that even if nextUrl is referencing the origin path, the parameters it has are relevant for the rewrite.

This adds the getUtils utility that's also used in base-server to handle the URL normalization, which also provides an interface for normalizing dynamic params from a ParsedUrlQuery.

Closes NEXT-1724
Fixes #48295

@ztanner
Copy link
Member Author

ztanner commented Nov 22, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@ztanner ztanner changed the title fix rewrites to edge paths fix rewrites to edge routes Nov 22, 2023
@ijjk
Copy link
Member

ijjk commented Nov 22, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Nov 22, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 11-22-fix_rewrites_to_edge_paths Change
buildDuration 10.4s 10.4s N/A
buildDurationCached 6s 5.8s N/A
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 424ms 416ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 11-22-fix_rewrites_to_edge_paths Change
199-HASH.js gzip 28.7 kB 28.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 240 B
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 11-22-fix_rewrites_to_edge_paths Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 11-22-fix_rewrites_to_edge_paths Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.28 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 11-22-fix_rewrites_to_edge_paths Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 11-22-fix_rewrites_to_edge_paths Change
index.html gzip 529 B 527 B N/A
link.html gzip 539 B 540 B N/A
withRouter.html gzip 522 B 522 B
Overall change 522 B 522 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 11-22-fix_rewrites_to_edge_paths Change
edge-ssr.js gzip 92.4 kB 92.4 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 11-22-fix_rewrites_to_edge_paths Change
middleware-b..fest.js gzip 626 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js 11-22-fix_rewrites_to_edge_paths Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.3 kB 93.3 kB
app-page-tur..prod.js gzip 94 kB 94 kB
app-page-tur..prod.js gzip 88.6 kB 88.6 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 87.9 kB 87.9 kB
app-route-ex...dev.js gzip 23.8 kB 23.8 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.5 kB 16.5 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 23.2 kB 23.2 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 49.1 kB 49.1 kB
Overall change 924 kB 924 kB
Commit: 64d08f2

@ztanner ztanner marked this pull request as ready for review November 23, 2023 01:11
@kodiakhq kodiakhq bot merged commit 0f642dc into canary Nov 23, 2023
60 checks passed
@kodiakhq kodiakhq bot deleted the 11-22-fix_rewrites_to_edge_paths branch November 23, 2023 05:25
@github-actions github-actions bot added the locked label Dec 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware rewrite to edge router handler - Invariant: no match found for request
3 participants