-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: disable deployment protection for e2e test project #58830
Merged
ztanner
merged 1 commit into
canary
from
11-23-disable_deployment_protection_for_e2e_test_project
Nov 23, 2023
Merged
ci: disable deployment protection for e2e test project #58830
ztanner
merged 1 commit into
canary
from
11-23-disable_deployment_protection_for_e2e_test_project
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
ztanner
changed the title
disable deployment protection for e2e test project
ci: disable deployment protection for e2e test project
Nov 23, 2023
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
ztanner
force-pushed
the
11-23-disable_deployment_protection_for_e2e_test_project
branch
from
November 23, 2023 14:59
7beada0
to
f28c3fb
Compare
ztanner
force-pushed
the
11-23-unify_reset_project_script
branch
from
November 23, 2023 15:08
8425389
to
04bbae1
Compare
ztanner
force-pushed
the
11-23-disable_deployment_protection_for_e2e_test_project
branch
from
November 23, 2023 15:08
f28c3fb
to
5803a70
Compare
ztanner
requested review from
a team,
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim and
wyattjoh
as code owners
November 23, 2023 15:09
ztanner
requested review from
manovotny and
delbaoliveira
and removed request for
a team
November 23, 2023 15:09
feedthejim
previously approved these changes
Nov 23, 2023
Tests Passed |
ztanner
force-pushed
the
11-23-unify_reset_project_script
branch
from
November 23, 2023 15:35
04bbae1
to
13f2296
Compare
ztanner
force-pushed
the
11-23-disable_deployment_protection_for_e2e_test_project
branch
from
November 23, 2023 15:35
5803a70
to
1a3effe
Compare
ijjk
previously approved these changes
Nov 23, 2023
ztanner
dismissed stale reviews from ijjk and feedthejim
November 23, 2023 17:40
The base branch was changed.
ztanner
force-pushed
the
11-23-disable_deployment_protection_for_e2e_test_project
branch
from
November 23, 2023 17:41
1a3effe
to
bec8658
Compare
ztanner
deleted the
11-23-disable_deployment_protection_for_e2e_test_project
branch
November 23, 2023 17:41
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we reset the test project on every e2e CI run, deployment protection is automatically enabled by default.
This adds an option to the reset project workflow to disable deployment protection. Our test runners need to be able to hit these pages from an unauthenticated browser in order for the tests to work.
Verified tests are running properly in this run (fixing any failing tests themselves are out of scope for this PR; will evaluate once the run finishes)
Closes NEXT-1732