Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Electron Typescript Example with Best Practices #58947

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Update Electron Typescript Example with Best Practices #58947

merged 6 commits into from
Nov 30, 2023

Conversation

Dylan700
Copy link
Contributor

Adding or Updating Examples

What?

I am updating the Electron Typescript example based on the latest best practices from electron. Packages have also been updated to their latest version.

Why?

The current example is outdated and does not meet security best practices.

How?

Updating dependencies and improving default security setup.

Relates to #44552

@Dylan700 Dylan700 requested review from a team as code owners November 27, 2023 00:24
@Dylan700 Dylan700 requested review from timeyoutakeit and leerob and removed request for a team November 27, 2023 00:24
@ijjk ijjk added the examples Issue/PR related to examples label Nov 27, 2023
@Dylan700
Copy link
Contributor Author

Dylan700 commented Nov 27, 2023

Hi @leerob, just made a new PR with the latest best practices. It seems not a lot has changed, but I've upgraded dependencies etc.

I was hoping to add a content security policy here too, but it seems that because the production build exports to static html, it makes the implementation of nonces difficult.

@Dylan700 Dylan700 requested a review from leerob November 28, 2023 22:12
@Dylan700
Copy link
Contributor Author

Apologies @leerob, it seems I forgot to run the lint after those changes! I've just updated the PR now, thanks heaps.

@leerob leerob merged commit d509c2d into vercel:canary Nov 30, 2023
32 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants