Fix bugs with baseUrl and mdxRs #58968

timneutkens · 2023-11-27T13:14:13Z

What?

Was investigating an issue with Turbopack and MDX, in the process found a few bugs:

When you have a tsconfig.json or jsconfig.json the baseUrl: '.' is used by default which causes the top-level directories to be available as e.g. design-system (without a prefix).
- This is not how TypeScript's default setting for baseUrl works. While it should resolve paths relative to . when none is specified it does not do additional resolving for the top level directories/files.
- When "baseUrl": "." is added to tsconfig.js explicitly it handles the top level directories.
modularizeImports and other SWC transforms weren't applied to .mdx files when experimental.mdxRs is enabled, which caused compilation to fail.
modularIzeImports and other SWC transforms are not applied to .mdx files when using Turbopack.
- @kwonoj is investigating this, will be handled in a follow-up PR.

How?

Added a test suite for modularizeImports with MDX tests
Removed the condition that disables swcLoader in webpack when using mdxRs
Changed the check for tsconfig.json / jsconfig.json baseUrl to include if it was implicitly or explicitly set, disabled the module resolving when it is implicitly set

timneutkens · 2023-11-27T13:14:24Z

Current dependencies on/for this PR:

canary
- PR Fix bugs with baseUrl and mdxRs #58968 👈

This stack of pull requests is managed by Graphite.

ijjk · 2023-11-27T13:25:07Z

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 11-27-Add_test_for_modularizeImports_with_MDX	Change
buildDuration	10.2s	10.3s	N/A
buildDurationCached	5.7s	5.8s	N/A
nodeModulesSize	199 MB	199 MB	⚠️ +6.48 kB
nextStartRea..uration (ms)	420ms	416ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 11-27-Add_test_for_modularizeImports_with_MDX	Change
199-HASH.js gzip	28.7 kB	28.7 kB	N/A
3f784ff6-HASH.js gzip	53.3 kB	53.3 kB	✓
494.HASH.js gzip	180 B	181 B	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	241 B	239 B	N/A
main-HASH.js gzip	31.7 kB	31.7 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	100 kB	100 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 11-27-Add_test_for_modularizeImports_with_MDX	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 11-27-Add_test_for_modularizeImports_with_MDX	Change
_app-HASH.js gzip	194 B	195 B	N/A
_error-HASH.js gzip	182 B	181 B	N/A
amp-HASH.js gzip	501 B	503 B	N/A
css-HASH.js gzip	322 B	323 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	✓
edge-ssr-HASH.js gzip	253 B	255 B	N/A
head-HASH.js gzip	348 B	347 B	N/A
hooks-HASH.js gzip	369 B	368 B	N/A
image-HASH.js gzip	4.27 kB	4.27 kB	N/A
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.61 kB	2.6 kB	N/A
routerDirect..HASH.js gzip	311 B	311 B	✓
script-HASH.js gzip	384 B	383 B	N/A
withRouter-HASH.js gzip	307 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.17 kB	3.17 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 11-27-Add_test_for_modularizeImports_with_MDX	Change
_buildManifest.js gzip	484 B	483 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 11-27-Add_test_for_modularizeImports_with_MDX	Change
index.html gzip	529 B	528 B	N/A
link.html gzip	540 B	541 B	N/A
withRouter.html gzip	524 B	523 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 11-27-Add_test_for_modularizeImports_with_MDX	Change
edge-ssr.js gzip	92.5 kB	92.5 kB	N/A
page.js gzip	145 kB	145 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 11-27-Add_test_for_modularizeImports_with_MDX	Change
middleware-b..fest.js gzip	627 B	625 B	N/A
middleware-r..fest.js gzip	150 B	151 B	N/A
middleware.js gzip	35.6 kB	35.6 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	1.92 kB	1.92 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 11-27-Add_test_for_modularizeImports_with_MDX	Change
app-page-exp...dev.js gzip	167 kB	167 kB	✓
app-page-exp..prod.js gzip	93.4 kB	93.4 kB	✓
app-page-tur..prod.js gzip	94.2 kB	94.2 kB	✓
app-page-tur..prod.js gzip	88.7 kB	88.7 kB	✓
app-page.run...dev.js gzip	137 kB	137 kB	✓
app-page.run..prod.js gzip	88 kB	88 kB	✓
app-route-ex...dev.js gzip	23.8 kB	23.8 kB	✓
app-route-ex..prod.js gzip	16.4 kB	16.4 kB	✓
app-route-tu..prod.js gzip	16.5 kB	16.5 kB	✓
app-route-tu..prod.js gzip	16 kB	16 kB	✓
app-route.ru...dev.js gzip	23.2 kB	23.2 kB	✓
app-route.ru..prod.js gzip	16 kB	16 kB	✓
pages-api-tu..prod.js gzip	9.37 kB	9.37 kB	✓
pages-api.ru...dev.js gzip	9.64 kB	9.64 kB	✓
pages-api.ru..prod.js gzip	9.37 kB	9.37 kB	✓
pages-turbo...prod.js gzip	21.8 kB	21.8 kB	✓
pages.runtim...dev.js gzip	22.5 kB	22.5 kB	✓
pages.runtim..prod.js gzip	21.8 kB	21.8 kB	✓
server.runti..prod.js gzip	49.2 kB	49.2 kB	✓
Overall change	925 kB	925 kB	✓

Commit: c4d65eb

ijjk · 2023-11-27T15:48:30Z

Tests Passed

packages/next/src/build/webpack-config.ts

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

### What Pairing with vercel/turbo#6602, enables ecma-related transform support in mdx. notably fixes test cases in vercel#58968 . With turbopack side fix, still modularize imports are not being applied as we limite it to .js* extension only. PR expands it to include mdx if mdx is enabled. PR is failling until turbopack side fix lands. Closes PACK-2045 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Add test for modularizeImports with MDX

cadea52

ijjk added area: tests created-by: Next.js team PRs by the Next.js team labels Nov 27, 2023

timneutkens added 2 commits November 27, 2023 14:15

Remove apage

e4e9638

Ensure SWC still runs even when mdxRs is enabled

7546806

timneutkens added 2 commits November 27, 2023 16:41

Don't apply baseUrl as modules directory when not provided

67e7e53

Add baseUrl to test

f51010a

timneutkens changed the title ~~Add test for modularizeImports with MDX~~ Fix bugs with baseUrl and mdxRs Nov 27, 2023

timneutkens marked this pull request as ready for review November 27, 2023 20:14

timneutkens requested review from ijjk, shuding, huozhi, feedthejim, ztanner, wyattjoh and a team as code owners November 27, 2023 20:17

kwonoj reviewed Nov 27, 2023

View reviewed changes

packages/next/src/build/webpack-config.ts Outdated Show resolved Hide resolved

This was referenced Nov 27, 2023

fix(mdx): support ecma transforms for the mdx assets vercel/turbo#6602

Merged

fix(turbopack): treat .mdx as valid ecma asset #58985

Merged

sokra requested changes Nov 27, 2023

View reviewed changes

packages/next/src/build/webpack-config.ts Outdated Show resolved Hide resolved

Update packages/next/src/build/webpack-config.ts

c4d65eb

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

ijjk added the type: next label Nov 28, 2023

timneutkens merged commit 7bdb61c into canary Nov 28, 2023
59 checks passed

timneutkens deleted the 11-27-Add_test_for_modularizeImports_with_MDX branch November 28, 2023 09:50

github-actions bot added the locked label Dec 12, 2023

github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bugs with baseUrl and mdxRs #58968

Fix bugs with baseUrl and mdxRs #58968

timneutkens commented Nov 27, 2023 •

edited

timneutkens commented Nov 27, 2023

ijjk commented Nov 27, 2023 •

edited

ijjk commented Nov 27, 2023 •

edited

Fix bugs with baseUrl and mdxRs #58968

Fix bugs with baseUrl and mdxRs #58968

Conversation

timneutkens commented Nov 27, 2023 • edited

What?

How?

timneutkens commented Nov 27, 2023

ijjk commented Nov 27, 2023 • edited

Stats from current PR

ijjk commented Nov 27, 2023 • edited

Tests Passed

timneutkens commented Nov 27, 2023 •

edited

ijjk commented Nov 27, 2023 •

edited

ijjk commented Nov 27, 2023 •

edited