-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(turbopack): treat .mdx as valid ecma asset #58985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
a team
as code owners
November 27, 2023 21:17
ijjk
added
Font (next/font)
Related to Next.js Font Optimization.
Turbopack
Related to Turbopack with Next.js.
created-by: Turbopack team
PRs by the turbopack team
type: next
labels
Nov 27, 2023
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
sokra
previously approved these changes
Nov 27, 2023
kdy1
previously approved these changes
Nov 27, 2023
sokra
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The turbopack bump is not correct. It's missing updates to the package.json and package-lock.json. Please use the next-link script to correctly update.
kwonoj
force-pushed
the
enable-mdx-js-asset
branch
from
November 27, 2023 23:45
a1fd792
to
729d68c
Compare
kwonoj
requested review from
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
November 27, 2023 23:45
kwonoj
force-pushed
the
enable-mdx-js-asset
branch
from
November 27, 2023 23:47
729d68c
to
f36eae0
Compare
sokra
approved these changes
Nov 28, 2023
timneutkens
approved these changes
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the turbopack team
Font (next/font)
Related to Next.js Font Optimization.
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Pairing with vercel/turbo#6602, enables ecma-related transform support in mdx. notably fixes test cases in #58968 .
With turbopack side fix, still modularize imports are not being applied as we limite it to .js* extension only. PR expands it to include mdx if mdx is enabled. PR is failling until turbopack side fix lands.
Closes PACK-2045