Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 303 status code for redirects in fetch actions #59017

Merged

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Nov 28, 2023

What?

A redirect that occurs during a fetch action will get a status code of 200, while the redirection logic is handled client-side.

Why?

In this scenario, the redirect is handled by the client router, so no Location is set on the action response. However for debugging / logging purposes, it'd be useful to still return the same status code used in other cases (see #58885)

How?

Rather than selectively setting the status to 303 in the non-fetch action case, this always applies it.

Closes NEXT-1745

@ijjk
Copy link
Member

ijjk commented Nov 28, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions Change
buildDuration 10.2s 10.2s N/A
buildDurationCached 5.9s 6s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +1.02 kB
nextStartRea..uration (ms) 427ms 420ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions Change
199-HASH.js gzip 30.7 kB 30.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 240 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions Change
index.html gzip 529 B 527 B N/A
link.html gzip 540 B 540 B
withRouter.html gzip 525 B 523 B N/A
Overall change 540 B 540 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions Change
edge-ssr.js gzip 92.6 kB 92.6 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions Change
middleware-b..fest.js gzip 624 B 624 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 35.7 kB 35.7 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 38.3 kB 38.3 kB
Next Runtimes
vercel/next.js canary vercel/next.js 11-28-use_303_status_code_for_redirects_in_fetch_actions Change
app-page-exp...dev.js gzip 168 kB 168 kB
app-page-exp..prod.js gzip 93.6 kB 93.6 kB
app-page-tur..prod.js gzip 94.4 kB 94.4 kB N/A
app-page-tur..prod.js gzip 88.9 kB 88.9 kB
app-page.run...dev.js gzip 138 kB 138 kB
app-page.run..prod.js gzip 88.3 kB 88.3 kB
app-route-ex...dev.js gzip 24.2 kB 24.2 kB
app-route-ex..prod.js gzip 16.8 kB 16.8 kB
app-route-tu..prod.js gzip 16.9 kB 16.9 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route.ru...dev.js gzip 23.6 kB 23.6 kB
app-route.ru..prod.js gzip 16.4 kB 16.4 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.3 kB 49.3 kB
Overall change 835 kB 835 kB
Diff details
Diff for page.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: fb266ab

@ztanner ztanner marked this pull request as ready for review November 28, 2023 15:25
@ztanner ztanner force-pushed the 11-24-update_status_codes_for_redirect_and_permanentRedirect_in_action_handlers branch from 7ef3827 to 1d2ab51 Compare November 28, 2023 15:29
@ztanner ztanner requested review from a team as code owners November 28, 2023 15:29
@ztanner ztanner requested review from manovotny and lydiahallie and removed request for a team November 28, 2023 15:29
@ztanner ztanner force-pushed the 11-28-use_303_status_code_for_redirects_in_fetch_actions branch from 77a1dca to a4d0781 Compare November 28, 2023 15:30
shuding
shuding previously approved these changes Nov 28, 2023
@ijjk
Copy link
Member

ijjk commented Nov 28, 2023

Tests Passed

Base automatically changed from 11-24-update_status_codes_for_redirect_and_permanentRedirect_in_action_handlers to canary November 29, 2023 08:35
@kodiakhq kodiakhq bot dismissed shuding’s stale review November 29, 2023 08:35

The base branch was changed.

@ztanner ztanner force-pushed the 11-28-use_303_status_code_for_redirects_in_fetch_actions branch from a4d0781 to 712c28f Compare November 29, 2023 14:55
@ztanner ztanner merged commit 77f8889 into canary Nov 29, 2023
68 checks passed
@ztanner ztanner deleted the 11-28-use_303_status_code_for_redirects_in_fetch_actions branch November 29, 2023 19:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants