fix(turbopack): add list of packages that should never be marked as e…

[ForsakenHarmony]

What?

Turbopack was missing the list of modules / requests that should never be marked as external:

next.js/packages/next/src/build/handle-externals.ts

Line 188 in 8d1c619

/^(?:private-next-pages\/|next\/(?:dist\/pages\/|(?:app|document|link|image|legacy\/image|constants|dynamic|script|navigation|headers|router)$)|string-hash|private-next-rsc-action-validate|private-next-rsc-action-client-wrapper|private-next-rsc-action-proxy$)/

This could lead to errors with i.e. next/image not receiving the correct image config.

Closes PACK-2047

[ijjk]

Stats from current PR

Default Build

General

	vercel/next.js canary	vercel/next.js hrmny/pack-2047-add-external-exclusions	Change
buildDuration	10.5s	10.5s	N/A
buildDurationCached	5.9s	6s	N/A
nodeModulesSize	199 MB	199 MB	✓
nextStartRea..uration (ms)	422ms	424ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js hrmny/pack-2047-add-external-exclusions	Change
199-HASH.js gzip	28.7 kB	28.7 kB	N/A
3f784ff6-HASH.js gzip	53.3 kB	53.3 kB	✓
494.HASH.js gzip	180 B	181 B	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	241 B	239 B	N/A
main-HASH.js gzip	31.7 kB	31.7 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	100 kB	100 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js hrmny/pack-2047-add-external-exclusions	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js hrmny/pack-2047-add-external-exclusions	Change
_app-HASH.js gzip	194 B	195 B	N/A
_error-HASH.js gzip	182 B	181 B	N/A
amp-HASH.js gzip	501 B	503 B	N/A
css-HASH.js gzip	322 B	323 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	✓
edge-ssr-HASH.js gzip	253 B	255 B	N/A
head-HASH.js gzip	348 B	347 B	N/A
hooks-HASH.js gzip	369 B	368 B	N/A
image-HASH.js gzip	4.27 kB	4.27 kB	N/A
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.61 kB	2.6 kB	N/A
routerDirect..HASH.js gzip	311 B	311 B	✓
script-HASH.js gzip	384 B	383 B	N/A
withRouter-HASH.js gzip	307 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.17 kB	3.17 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js hrmny/pack-2047-add-external-exclusions	Change
_buildManifest.js gzip	484 B	483 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js hrmny/pack-2047-add-external-exclusions	Change
index.html gzip	527 B	528 B	N/A
link.html gzip	539 B	541 B	N/A
withRouter.html gzip	525 B	522 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js hrmny/pack-2047-add-external-exclusions	Change
edge-ssr.js gzip	92.5 kB	92.5 kB	N/A
page.js gzip	145 kB	145 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js hrmny/pack-2047-add-external-exclusions	Change
middleware-b..fest.js gzip	626 B	627 B	N/A
middleware-r..fest.js gzip	150 B	151 B	N/A
middleware.js gzip	35.6 kB	35.6 kB	✓
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	37.6 kB	37.6 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js hrmny/pack-2047-add-external-exclusions	Change
app-page-exp...dev.js gzip	167 kB	167 kB	✓
app-page-exp..prod.js gzip	93.4 kB	93.4 kB	✓
app-page-tur..prod.js gzip	94.2 kB	94.2 kB	✓
app-page-tur..prod.js gzip	88.7 kB	88.7 kB	✓
app-page.run...dev.js gzip	137 kB	137 kB	✓
app-page.run..prod.js gzip	88.1 kB	88.1 kB	✓
app-route-ex...dev.js gzip	23.8 kB	23.8 kB	✓
app-route-ex..prod.js gzip	16.5 kB	16.5 kB	✓
app-route-tu..prod.js gzip	16.5 kB	16.5 kB	✓
app-route-tu..prod.js gzip	16 kB	16 kB	✓
app-route.ru...dev.js gzip	23.2 kB	23.2 kB	✓
app-route.ru..prod.js gzip	16 kB	16 kB	✓
pages-api-tu..prod.js gzip	9.37 kB	9.37 kB	✓
pages-api.ru...dev.js gzip	9.64 kB	9.64 kB	✓
pages-api.ru..prod.js gzip	9.37 kB	9.37 kB	✓
pages-turbo...prod.js gzip	21.8 kB	21.8 kB	✓
pages.runtim...dev.js gzip	22.5 kB	22.5 kB	✓
pages.runtim..prod.js gzip	21.8 kB	21.8 kB	✓
server.runti..prod.js gzip	49.2 kB	49.2 kB	✓
Overall change	925 kB	925 kB	✓

Commit: 36b476b

[timneutkens]

Can you add another comment on the webpack side so that if someone changes them they don't accidentally forget to change this one.

[sokra]

I think these private-next-* stuff doesn't even exist in turbopack, but fine for now.