Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 10-route-handlers.mdx #59021

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Update 10-route-handlers.mdx #59021

merged 2 commits into from
Dec 6, 2023

Conversation

pkellner
Copy link
Contributor

TypeScript creates an error if you don't explicitly set a header value. undefined is no good.

TypeScript creates an error if you don't explicitly set a header value. undefined is no good.
@pkellner pkellner requested review from a team as code owners November 28, 2023 16:31
@pkellner pkellner requested review from timeyoutakeit and delbaoliveira and removed request for a team November 28, 2023 16:31
@ijjk
Copy link
Member

ijjk commented Nov 28, 2023

Allow CI Workflow Run

  • approve CI run for commit: 18bb37e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Nov 28, 2023

Allow CI Workflow Run

  • approve CI run for commit: 18bb37e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@pkellner
Copy link
Contributor Author

Allow CI Workflow Run

  • approve CI run for commit: 18bb37e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

I'm not following @ijjk, is this really you commenting or a bot somehow. If really you, what is "this" in "Note: this should only be enabled once the ..."

@leerob leerob merged commit 4a52268 into vercel:canary Dec 6, 2023
31 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants