Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump nissuer (issue validator) #59060

Merged
merged 1 commit into from
Nov 29, 2023
Merged

chore: bump nissuer (issue validator) #59060

merged 1 commit into from
Nov 29, 2023

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Nov 29, 2023

What?

Bumping the issue validator action nissuer

Why?

It introduces two new features:

  • Comments made by members of the Vercel organization are never hidden to avoid hiding useful information. Example: https://github.com/vercel/next.js/actions/runs/6780069984/job/18428144215
  • A new option was added to do not allow https://github.com/vercel/next.js.* URLs as valid reproductions, as they are non-modified versions. We should require the reporter to go through the process of creating an isolated reproduction that we can clone and verify easily.

How?

See https://github.com/balazsorban44/nissuer/releases/tag/1.8.0

@balazsorban44 balazsorban44 requested review from a team as code owners November 29, 2023 11:51
@balazsorban44 balazsorban44 requested review from ismaelrumzan and molebox and removed request for a team November 29, 2023 11:51
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Nov 29, 2023
@@ -30,6 +30,7 @@ jobs:
}
reproduction-comment: '.github/invalid-link.md'
reproduction-hosts: 'github.com,codesandbox.io'
reproduction-blocklist: 'github.com/vercel/next.js.*'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if this is desired or we have other patterns we want to include on this list

@ijjk
Copy link
Member

ijjk commented Nov 29, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js chore/bump-nissuer Change
buildDuration 10.6s 10.7s ⚠️ +138ms
buildDurationCached 5.9s 6.1s ⚠️ +233ms
nodeModulesSize 199 MB 199 MB
nextStartRea..uration (ms) 422ms 419ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js chore/bump-nissuer Change
199-HASH.js gzip 30.7 kB 30.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/bump-nissuer Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/bump-nissuer Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/bump-nissuer Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/bump-nissuer Change
index.html gzip 529 B 527 B N/A
link.html gzip 540 B 540 B
withRouter.html gzip 525 B 523 B N/A
Overall change 540 B 540 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js chore/bump-nissuer Change
edge-ssr.js gzip 92.6 kB 92.6 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js chore/bump-nissuer Change
middleware-b..fest.js gzip 627 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 35.7 kB 35.7 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js chore/bump-nissuer Change
app-page-exp...dev.js gzip 168 kB 168 kB
app-page-exp..prod.js gzip 93.6 kB 93.6 kB
app-page-tur..prod.js gzip 94.4 kB 94.4 kB
app-page-tur..prod.js gzip 88.9 kB 88.9 kB
app-page.run...dev.js gzip 138 kB 138 kB
app-page.run..prod.js gzip 88.3 kB 88.3 kB
app-route-ex...dev.js gzip 24.2 kB 24.2 kB
app-route-ex..prod.js gzip 16.8 kB 16.8 kB
app-route-tu..prod.js gzip 16.9 kB 16.9 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route.ru...dev.js gzip 23.6 kB 23.6 kB
app-route.ru..prod.js gzip 16.4 kB 16.4 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.3 kB 49.3 kB
Overall change 929 kB 929 kB
Commit: 5387c9d

@kodiakhq kodiakhq bot merged commit d6d41dc into canary Nov 29, 2023
68 checks passed
@kodiakhq kodiakhq bot deleted the chore/bump-nissuer branch November 29, 2023 14:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants