-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support outputFileTracing in App Router #59139
Merged
ijjk
merged 2 commits into
vercel:canary
from
smaeda-ks:shohei/support-outputFileTracing-app-router
Dec 4, 2023
Merged
feat: support outputFileTracing in App Router #59139
ijjk
merged 2 commits into
vercel:canary
from
smaeda-ks:shohei/support-outputFileTracing-app-router
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaeda-ks
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
ztanner,
feedthejim and
a team
as code owners
December 1, 2023 00:12
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
Diff detailsDiff for page.jsDiff too large to display Diff for edge-ssr.jsDiff too large to display Diff for 199-HASH.jsDiff too large to display Diff for app-page-exp..ntime.dev.jsfailed to diff Diff for app-page-exp..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page.runtime.dev.jsDiff too large to display Diff for app-page.runtime.prod.jsDiff too large to display Diff for server.runtime.prod.jsDiff too large to display |
smaeda-ks
force-pushed
the
shohei/support-outputFileTracing-app-router
branch
3 times, most recently
from
December 4, 2023 04:57
32dadbf
to
7eb0828
Compare
smaeda-ks
force-pushed
the
shohei/support-outputFileTracing-app-router
branch
from
December 4, 2023 04:58
7eb0828
to
a85654c
Compare
1 task
ijjk
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54245
https://nextjs.org/docs/app/api-reference/next-config-js/output#caveats
Currently,
outputFileTracingExcludes
/outputFileTracingIncludes
only works with Pages router. This PR adds support for App router.