Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing echo in daily turbopack reporting #59255

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix missing echo in daily turbopack reporting #59255

merged 1 commit into from
Dec 4, 2023

Conversation

ForsakenHarmony
Copy link
Member

@ForsakenHarmony ForsakenHarmony commented Dec 4, 2023 •
edited by padmaia

What?

GitHub workflow commands need to be echoed

Closes PACK-2075

@ForsakenHarmony ForsakenHarmony requested review from a team as code owners December 4, 2023 16:59
@ForsakenHarmony ForsakenHarmony requested review from S3Prototype and leerob and removed request for a team December 4, 2023 16:59
@ijjk ijjk added the created-by: Turbopack team PRs by the turbopack team label Dec 4, 2023
@timneutkens timneutkens merged commit d348e4b into canary Dec 4, 2023
60 of 66 checks passed
@timneutkens timneutkens deleted the hrmny/fix-daily-test-reporting branch December 4, 2023 17:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens timneutkens approved these changes

@S3Prototype S3Prototype Awaiting requested review from S3Prototype S3Prototype is a code owner automatically assigned from vercel/devex

@leerob leerob Awaiting requested review from leerob leerob is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the turbopack team locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ForsakenHarmony @huozhi @timneutkens @ijjk