Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dev parallelism in daily turbopack tests #59287

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix dev parallelism in daily turbopack tests #59287

merged 2 commits into from
Dec 5, 2023

Conversation

ForsakenHarmony
Copy link
Member

@ForsakenHarmony ForsakenHarmony commented Dec 5, 2023 •
edited by padmaia

Also fixes the retry running on forks (hopefully for real this time)

Closes PACK-2087

@ForsakenHarmony ForsakenHarmony requested review from a team as code owners December 5, 2023 13:46
@ForsakenHarmony ForsakenHarmony requested review from manovotny and lydiahallie and removed request for a team December 5, 2023 13:46
@ijjk ijjk added the created-by: Turbopack team PRs by the turbopack team label Dec 5, 2023
ForsakenHarmony
ForsakenHarmony commented Dec 5, 2023
View reviewed changes
.github/workflows/nextjs-integration-test.yml
sudo npx playwright install-deps && pnpm playwright install
NEXT_TEST_MODE=dev TURBOPACK=1 node run-tests.js -g ${{ matrix.group }}/3 -c ${TEST_CONCURRENCY} --type development
ls test/turbopack-test-junit-report
NEXT_TEST_MODE=dev TURBOPACK=1 node run-tests.js -g ${{ matrix.group }}/6 -c ${TEST_CONCURRENCY} --type development
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the fix, the rest is some cleanup

ForsakenHarmony
ForsakenHarmony commented Dec 5, 2023
View reviewed changes
.github/workflows/nextjs-integration-test.yml
# It is currently expected to fail some of next.js integration test, do not fail CI check.
continue-on-error: true
env:
# marker to parse log output, do not delete / change.
NEXT_INTEGRATION_TEST: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything using this across both repos, so I've removed it for now

@ijjk
Copy link
Member

ijjk commented Dec 5, 2023 •
edited

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 5, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js hrmny/fix-daily-test-reporting Change
buildDuration 10.8s 10.8s N/A
buildDurationCached 6s 6.7s ⚠️ +714ms
nodeModulesSize 199 MB 199 MB ✓
nextStartRea..uration (ms) 428ms 424ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hrmny/fix-daily-test-reporting Change
199-HASH.js gzip 30.6 kB 30.6 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 100 kB 100 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hrmny/fix-daily-test-reporting Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js hrmny/fix-daily-test-reporting Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB ✓
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B ✓
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.17 kB 3.17 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js hrmny/fix-daily-test-reporting Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js hrmny/fix-daily-test-reporting Change
index.html gzip 528 B 527 B N/A
link.html gzip 539 B 541 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hrmny/fix-daily-test-reporting Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 146 kB 146 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js hrmny/fix-daily-test-reporting Change
middleware-b..fest.js gzip 628 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js hrmny/fix-daily-test-reporting Change
app-page-exp...dev.js gzip 168 kB 168 kB ✓
app-page-exp..prod.js gzip 93.8 kB 93.8 kB ✓
app-page-tur..prod.js gzip 94.5 kB 94.5 kB ✓
app-page-tur..prod.js gzip 89.1 kB 89.1 kB ✓
app-page.run...dev.js gzip 138 kB 138 kB ✓
app-page.run..prod.js gzip 88.4 kB 88.4 kB ✓
app-route-ex...dev.js gzip 24.2 kB 24.2 kB ✓
app-route-ex..prod.js gzip 16.8 kB 16.8 kB ✓
app-route-tu..prod.js gzip 16.9 kB 16.9 kB ✓
app-route-tu..prod.js gzip 16.4 kB 16.4 kB ✓
app-route.ru...dev.js gzip 23.6 kB 23.6 kB ✓
app-route.ru..prod.js gzip 16.4 kB 16.4 kB ✓
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB ✓
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 22.6 kB 22.6 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 49.4 kB 49.4 kB ✓
Overall change 930 kB 930 kB ✓
Commit: acff18c

@ForsakenHarmony ForsakenHarmony merged commit b88e263 into canary Dec 5, 2023
68 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/fix-daily-test-reporting branch December 5, 2023 14:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@manovotny manovotny Awaiting requested review from manovotny manovotny is a code owner automatically assigned from vercel/devex

@lydiahallie lydiahallie Awaiting requested review from lydiahallie lydiahallie is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the turbopack team locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ForsakenHarmony @ijjk @timneutkens