Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove additional static prefetch code #59313

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Dec 6, 2023

This is a continuation from #58783 to remove the remaining code related to static prefetching.

@ztanner
Copy link
Member Author

ztanner commented Dec 6, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@ztanner ztanner force-pushed the 12-05-remove_additional_static_prefetch_code branch 3 times, most recently from 5502273 to ec05297 Compare December 6, 2023 04:25
@ztanner ztanner force-pushed the 12-05-remove_additional_static_prefetch_code branch from ec05297 to 9b3d5d8 Compare December 6, 2023 04:25
@ijjk
Copy link
Member

ijjk commented Dec 6, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 12-05-remove_additional_static_prefetch_code Change
buildDuration 10.8s 10.7s N/A
buildDurationCached 6s 6s N/A
nodeModulesSize 200 MB 200 MB N/A
nextStartRea..uration (ms) 424ms 418ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-05-remove_additional_static_prefetch_code Change
170-HASH.js gzip 30.3 kB 30.3 kB N/A
199.HASH.js gzip 181 B 185 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 241 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-05-remove_additional_static_prefetch_code Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 12-05-remove_additional_static_prefetch_code Change
_app-HASH.js gzip 195 B 194 B N/A
_error-HASH.js gzip 183 B 182 B N/A
amp-HASH.js gzip 501 B 501 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 255 B
head-HASH.js gzip 349 B 350 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.6 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 309 B N/A
script-HASH.js gzip 384 B 384 B
withRouter-HASH.js gzip 307 B 306 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.57 kB 1.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-05-remove_additional_static_prefetch_code Change
_buildManifest.js gzip 483 B 483 B
Overall change 483 B 483 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-05-remove_additional_static_prefetch_code Change
index.html gzip 528 B 528 B
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 524 B
Overall change 1.59 kB 1.59 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-05-remove_additional_static_prefetch_code Change
edge-ssr.js gzip 93.5 kB 93.5 kB N/A
page.js gzip 146 kB 146 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-05-remove_additional_static_prefetch_code Change
middleware-b..fest.js gzip 622 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary vercel/next.js 12-05-remove_additional_static_prefetch_code Change
app-page-exp...dev.js gzip 168 kB 168 kB
app-page-exp..prod.js gzip 94 kB 94 kB
app-page-tur..prod.js gzip 94.7 kB 94.7 kB
app-page-tur..prod.js gzip 89.3 kB 89.3 kB
app-page.run...dev.js gzip 138 kB 138 kB
app-page.run..prod.js gzip 88.6 kB 88.6 kB
app-route-ex...dev.js gzip 24.2 kB 24.1 kB N/A
app-route-ex..prod.js gzip 16.8 kB 16.8 kB N/A
app-route-tu..prod.js gzip 16.8 kB 16.8 kB N/A
app-route-tu..prod.js gzip 16.4 kB 16.4 kB N/A
app-route.ru...dev.js gzip 23.6 kB 23.6 kB N/A
app-route.ru..prod.js gzip 16.4 kB 16.4 kB N/A
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.4 kB 49.4 kB
Overall change 817 kB 817 kB
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 170-HASH.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: 31a4b9e

@ztanner ztanner marked this pull request as ready for review December 6, 2023 04:40
@ztanner ztanner merged commit 59f7ca8 into canary Dec 6, 2023
69 checks passed
@ztanner ztanner deleted the 12-05-remove_additional_static_prefetch_code branch December 6, 2023 05:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants