New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
with-next-page-transitions example is failing #6086
Comments
Hello! PageTransition.propTypes = {
children: PropTypes.node.isRequired,
classNames: PropTypes.string.isRequired,
- timeout: timeoutsShape.isRequired,
+ timeout: timeoutsShape,
loadingComponent: PropTypes.element,
loadingDelay: PropTypes.number,
loadingCallbackName: PropTypes.string,
/* eslint-disable react/require-default-props */
loadingTimeout: (props, ...args) => {
let pt = timeoutsShape
if (props.loadingComponent) pt = pt.isRequired
return pt(props, ...args)
},
loadingClassNames: (props, ...args) => {
let pt = PropTypes.string
if (props.loadingTimeout) pt = pt.isRequired
return pt(props, ...args)
},
/* eslint-enable react/require-default-props */
monkeyPatchScrolling: PropTypes.bool,
}
PageTransition.defaultProps = {
loadingComponent: null,
loadingCallbackName: 'pageTransitionReadyToEnter',
loadingDelay: 500,
monkeyPatchScrolling: false,
+ timeout: null
} upd: I did a PR to the next-page-transitions |
It works. Thank you! So this seems to be an Issue with next-page-transitions and not with the example. I will close this Issue then. |
The problem is a dep on You can fix it just by adding this code to your package.json: "resolutions": {
"next-page-transitions/react-transition-group": "2.5.1"
} Or just wait for @teleginzhenya PR |
Examples bug report
Example name
with-next-page-transitions
Describe the bug
After following the description on https://github.com/zeit/next.js/tree/canary/examples/with-next-page-transitions and accessing the site, the server throws an Error
To Reproduce
npx create-next-app --example with-next-page-transitions with-next-page-transitions
cd with-next-page-transitions
npm install
npm run build
npm start
Additional context
I've found this Issue but I think its different because it was a problem during the build. for me the build works fine. Full output:
The text was updated successfully, but these errors were encountered: