Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade edge-runtime #61030

Merged
merged 6 commits into from Feb 1, 2024
Merged

build: upgrade edge-runtime #61030

merged 6 commits into from Feb 1, 2024

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Jan 23, 2024 •
edited by styfle

It exposes performance constructor

Closes #60433
Closes NEXT-2195

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 23, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Jan 23, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@edge-runtime/cookies@4.0.3 None 0 56.9 kB kikobeats
npm/@edge-runtime/jest-environment@2.3.7 Transitive: environment, eval, filesystem, unsafe +49 6.57 MB kikobeats
npm/@edge-runtime/primitives@4.0.4 eval, unsafe 0 751 kB kikobeats
npm/edge-runtime@2.5.7 network Transitive: environment, eval, unsafe +12 1.09 MB kikobeats

🚮 Removed packages: npm/@edge-runtime/cookies@4.0.2, npm/@edge-runtime/jest-environment@2.3.4, npm/@edge-runtime/primitives@4.0.2, npm/edge-runtime@2.5.4

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Jan 23, 2024 •
edited

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary Kikobeats/next.js edge-runtime Change
buildDuration 11.7s 11.7s N/A
buildDurationCached 6.1s 5.3s N/A
nodeModulesSize 200 MB 200 MB ⚠️ +880 B
nextStartRea..uration (ms) 425ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary Kikobeats/next.js edge-runtime Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB ✓
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.9 kB 29.9 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 238 B 240 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 100 kB 100 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Kikobeats/next.js edge-runtime Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Kikobeats/next.js edge-runtime Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B ✓
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 608 B 608 B ✓
Client Build Manifests
vercel/next.js canary Kikobeats/next.js edge-runtime Change
_buildManifest.js gzip 484 B 484 B ✓
Overall change 484 B 484 B ✓
Rendered Page Sizes
vercel/next.js canary Kikobeats/next.js edge-runtime Change
index.html gzip 527 B 526 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 521 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary Kikobeats/next.js edge-runtime Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 150 kB 150 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary Kikobeats/next.js edge-runtime Change
middleware-b..fest.js gzip 625 B 623 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Next Runtimes
vercel/next.js canary Kikobeats/next.js edge-runtime Change
app-page-exp...dev.js gzip 170 kB 170 kB ✓
app-page-exp..prod.js gzip 95.8 kB 95.8 kB ✓
app-page-tur..prod.js gzip 96.4 kB 96.4 kB ✓
app-page-tur..prod.js gzip 91 kB 91 kB ✓
app-page.run...dev.js gzip 142 kB 142 kB ✓
app-page.run..prod.js gzip 90.3 kB 90.3 kB ✓
app-route-ex...dev.js gzip 22.2 kB 22.2 kB ✓
app-route-ex..prod.js gzip 14.9 kB 14.9 kB ✓
app-route-tu..prod.js gzip 14.9 kB 14.9 kB ✓
app-route-tu..prod.js gzip 14.5 kB 14.5 kB ✓
app-route.ru...dev.js gzip 21.7 kB 21.7 kB ✓
app-route.ru..prod.js gzip 14.5 kB 14.5 kB ✓
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB ✓
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB ✓
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB ✓
pages-turbo...prod.js gzip 22 kB 22 kB ✓
pages.runtim...dev.js gzip 22.7 kB 22.7 kB ✓
pages.runtim..prod.js gzip 22 kB 22 kB ✓
server.runti..prod.js gzip 49.7 kB 49.7 kB ✓
Overall change 933 kB 933 kB ✓
Commit: f10161f

@ijjk
Copy link
Member

ijjk commented Jan 23, 2024 •
edited

Tests Passed

@Kikobeats Kikobeats force-pushed the edge-runtime branch 2 times, most recently from 7940a4f to 9c9b2ee Compare January 24, 2024 11:10
@Kikobeats Kikobeats force-pushed the edge-runtime branch 3 times, most recently from 608d45f to bc4b9cb Compare January 25, 2024 08:51
@Kikobeats Kikobeats force-pushed the edge-runtime branch 2 times, most recently from db28c9d to 1c21d5d Compare February 1, 2024 10:54
@timneutkens timneutkens merged commit 461aa51 into vercel:canary Feb 1, 2024
67 checks passed
@Kikobeats Kikobeats deleted the edge-runtime branch February 1, 2024 12:10
ijjk added a commit that referenced this pull request Feb 5, 2024
@ijjk
Revert "build: upgrade edge-runtime (#61030)"
a621e64 
This reverts commit 461aa51.
@ijjk ijjk mentioned this pull request Feb 5, 2024
Merged
ijjk added a commit that referenced this pull request Feb 5, 2024
@ijjk
Revert "build: upgrade edge-runtime" (#61686)
2ad058d 
See here for additional context
vercel/edge-runtime#795 but TLDR is due to a bug
in the `npmcli` we aren't able to publish Next.js releases after this
package was upgraded.

We can re-land the upgrade after that PR is landed/published. 

Reverts #61030

Closes NEXT-2367
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@feedthejim feedthejim feedthejim approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Kikobeats @ijjk @styfle @ForsakenHarmony @feedthejim @timneutkens