Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config-next: allow typescript eslint v7 #62137

Merged

Conversation

belgattitude
Copy link
Contributor

@belgattitude belgattitude commented Feb 16, 2024

What?

Allow typescript-eslint v7 support

Why?

Allow compatibility with typescript eslint v7, pave the way to support eslint flat config and possibly typescript 5.4

How?

Add a v7 to the allowed versions in eslint-config-next dependencies and regenerate the lock with pnpm install. Be aware that some eslint peer dev deps have been updated in the process. See the lock

Tested with pnpm build && ppm lint

Close

@ijjk
Copy link
Member

ijjk commented Feb 16, 2024

Allow CI Workflow Run

  • approve CI run for commit: 8888d8b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

socket-security bot commented Feb 16, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@typescript-eslint/parser@6.1.0

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Feb 16, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 16, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary belgattitude/next.js eslint-config-allow-typescript-eslint-v7 Change
buildDuration 19.8s 20s ⚠️ +220ms
buildDurationCached 7.7s 7.8s ⚠️ +110ms
nodeModulesSize 196 MB 196 MB
nextStartRea..uration (ms) 424ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary belgattitude/next.js eslint-config-allow-typescript-eslint-v7 Change
1068-HASH.js gzip 30.3 kB 30.3 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 5.04 kB 5.03 kB N/A
8423.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.1 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 47.1 kB 47.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary belgattitude/next.js eslint-config-allow-typescript-eslint-v7 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary belgattitude/next.js eslint-config-allow-typescript-eslint-v7 Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 931 B 931 B
Client Build Manifests
vercel/next.js canary belgattitude/next.js eslint-config-allow-typescript-eslint-v7 Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary belgattitude/next.js eslint-config-allow-typescript-eslint-v7 Change
index.html gzip 530 B 529 B N/A
link.html gzip 542 B 539 B N/A
withRouter.html gzip 525 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary belgattitude/next.js eslint-config-allow-typescript-eslint-v7 Change
edge-ssr.js gzip 94.5 kB 94.5 kB N/A
page.js gzip 151 kB 151 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary belgattitude/next.js eslint-config-allow-typescript-eslint-v7 Change
middleware-b..fest.js gzip 626 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 44.6 kB 44.6 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 2.1 kB 2.1 kB
Next Runtimes
vercel/next.js canary belgattitude/next.js eslint-config-allow-typescript-eslint-v7 Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.9 kB 95.9 kB
app-page-tur..prod.js gzip 97.6 kB 97.6 kB
app-page-tur..prod.js gzip 92 kB 92 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 90.6 kB 90.6 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.47 kB 9.47 kB
pages-api.ru...dev.js gzip 9.74 kB 9.74 kB
pages-api.ru..prod.js gzip 9.47 kB 9.47 kB
pages-turbo...prod.js gzip 22.1 kB 22.1 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22.1 kB 22.1 kB
server.runti..prod.js gzip 50.1 kB 50.1 kB
Overall change 927 kB 927 kB
build cache Overall increase ⚠️
vercel/next.js canary belgattitude/next.js eslint-config-allow-typescript-eslint-v7 Change
0.pack gzip 1.55 MB 1.55 MB N/A
index.pack gzip 103 kB 104 kB ⚠️ +901 B
Overall change 103 kB 104 kB ⚠️ +901 B
Commit: c7c217c

@belgattitude
Copy link
Contributor Author

The CI failures seems unrelated … let me know if I can help.

there’s a small size increase in next cache too

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Also see related PR #52845

@styfle styfle merged commit cd6dacd into vercel:canary Feb 21, 2024
66 checks passed
@github-actions github-actions bot added the locked label Mar 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issue with typescript eslint v7
4 participants