Verify correctness of externals

[sokra]

What?

• Verify correctness of externals
• error when packages can't be made external

Why?

• Resolving to incorrect externals might lead to runtime errors
• Give users hints how to fix these issues

How?

Closes PACK-2535

[ijjk]

Stats from current PR

Default Build

General

	vercel/next.js canary	vercel/next.js sokra/externals-verify	Change
buildDuration	14.3s	14.3s	N/A
buildDurationCached	7.6s	7.8s	⚠️ +220ms
nodeModulesSize	197 MB	197 MB	✓
nextStartRea..uration (ms)	408ms	407ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js sokra/externals-verify	Change
1068-HASH.js gzip	30.3 kB	30.3 kB	N/A
3f784ff6-HASH.js gzip	53.5 kB	53.5 kB	N/A
4944-HASH.js gzip	5.04 kB	5.03 kB	N/A
8423.HASH.js gzip	181 B	181 B	✓
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	241 B	242 B	N/A
main-HASH.js gzip	32.1 kB	32.1 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	47.1 kB	47.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js sokra/externals-verify	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js sokra/externals-verify	Change
_app-HASH.js gzip	196 B	196 B	✓
_error-HASH.js gzip	184 B	183 B	N/A
amp-HASH.js gzip	503 B	504 B	N/A
css-HASH.js gzip	323 B	324 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.51 kB	N/A
edge-ssr-HASH.js gzip	258 B	259 B	N/A
head-HASH.js gzip	353 B	351 B	N/A
hooks-HASH.js gzip	370 B	370 B	✓
image-HASH.js gzip	4.21 kB	4.2 kB	N/A
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.68 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	313 B	314 B	N/A
script-HASH.js gzip	386 B	385 B	N/A
withRouter-HASH.js gzip	309 B	311 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	931 B	931 B	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js sokra/externals-verify	Change
_buildManifest.js gzip	485 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js sokra/externals-verify	Change
index.html gzip	528 B	526 B	N/A
link.html gzip	540 B	540 B	✓
withRouter.html gzip	523 B	522 B	N/A
Overall change	540 B	540 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js sokra/externals-verify	Change
edge-ssr.js gzip	2.29 kB	2.29 kB	N/A
page.js gzip	2.98 kB	2.98 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js sokra/externals-verify	Change
middleware-b..fest.js gzip	625 B	626 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	466 B	465 B	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js sokra/externals-verify	Change
app-page-exp...dev.js gzip	166 kB	166 kB	✓
app-page-exp..prod.js gzip	95.9 kB	95.9 kB	✓
app-page-tur..prod.js gzip	97.6 kB	97.6 kB	✓
app-page-tur..prod.js gzip	92 kB	92 kB	✓
app-page.run...dev.js gzip	136 kB	136 kB	✓
app-page.run..prod.js gzip	90.6 kB	90.6 kB	✓
app-route-ex...dev.js gzip	22 kB	22 kB	✓
app-route-ex..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.6 kB	14.6 kB	✓
app-route.ru...dev.js gzip	21.7 kB	21.7 kB	✓
app-route.ru..prod.js gzip	14.6 kB	14.6 kB	✓
pages-api-tu..prod.js gzip	9.47 kB	9.47 kB	✓
pages-api.ru...dev.js gzip	9.74 kB	9.74 kB	✓
pages-api.ru..prod.js gzip	9.47 kB	9.47 kB	✓
pages-turbo...prod.js gzip	22.1 kB	22.1 kB	✓
pages.runtim...dev.js gzip	22.8 kB	22.8 kB	✓
pages.runtim..prod.js gzip	22.1 kB	22.1 kB	✓
server.runti..prod.js gzip	50.2 kB	50.2 kB	✓
Overall change	927 kB	927 kB	✓

build cache

	vercel/next.js canary	vercel/next.js sokra/externals-verify	Change
0.pack gzip	1.49 MB	1.49 MB	N/A
index.pack gzip	104 kB	104 kB	N/A
Overall change	0 B	0 B	✓

Commit: 5454f17

[ijjk]

Failing test suites

Commit: 5454f17

TURBOPACK=1 pnpm test-dev test/e2e/app-dir/not-found-default/index.test.ts (turbopack)

• app dir - not found with default 404 page > should render default 404 with root layout for non-existent page

Expand output

● app dir - not found with default 404 page › should render default 404 with root layout for non-existent page

expect(received).not.toContain(expected) // indexOf

Expected substring: not "/_error"
Received string:        "yarn run v1.22.19
$ /tmp/next-install-bcdf25272d2a05f34be8e7309ec1b51c8541e2f225536fff20c67e034067fe02/node_modules/.bin/next --turbo
   ▲ Next.js 14.1.1-canary.62 (turbo)
   - Local:        http://localhost:36003

Creating turbopack project {
  dir: '/tmp/next-install-bcdf25272d2a05f34be8e7309ec1b51c8541e2f225536fff20c67e034067fe02',
  testMode: true
}
 ✓ Ready in 1811ms
 ○ Compiling / ...
 ✓ Compiled / in 1860ms
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client

  36 |         const cliOutput = next.cliOutput
  37 |         expect(cliOutput).toContain('/not-found')
> 38 |         expect(cliOutput).not.toContain('/_error')
     |                               ^
  39 |       }
  40 |     })
  41 |

  at handleRequest (../../../../../../tmp/next-install-bcdf25272d2a05f34be8e7309ec1b51c8541e2f225536fff20c67e034067fe02/node_modules/.pnpm/file+..+next-repo-1bfb0c709fb83486d2cadbf7e845dba72fe1b0c82e1b14b8e012953ae7b763fb+packages+n_zm6554le3bl6ju734haewspgca/node_modules/next/dist/server/lib/router-server.js:320:17)
  at async requestHandlerImpl (../../../../../../tmp/next-install-bcdf25272d2a05f34be8e7309ec1b51c8541e2f225536fff20c67e034067fe02/node_modules/.pnpm/file+..+next-repo-1bfb0c709fb83486d2cadbf7e845dba72fe1b0c82e1b14b8e012953ae7b763fb+packages+n_zm6554le3bl6ju734haewspgca/node_modules/next/dist/server/lib/router-server.js:339:13)
  at async Server.requestListener (../../../../../../tmp/next-install-bcdf25272d2a05f34be8e7309ec1b51c8541e2f225536fff20c67e034067fe02/node_modules/.pnpm/file+..+next-repo-1bfb0c709fb83486d2cadbf7e845dba72fe1b0c82e1b14b8e012953ae7b763fb+packages+n_zm6554le3bl6ju734haewspgca/node_modules/next/dist/server/lib/start-server.js:140:13) {
    code: 'ERR_HTTP_HEADERS_SENT'
  }
   ○ Compiling /_error ...
   ✓ Compiled /_error in 765ms
   ✓ Compiled /not-found in 156ms
  "
  at Object.toContain (e2e/app-dir/not-found-default/index.test.ts:38:31)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/interception-route-prefetch-cache/interception-route-prefetch-cache.test.ts (PPR)

• interception-route-prefetch-cache > runtime = edge > should render the correct interception when two distinct layouts share the same path structure

Expand output

● interception-route-prefetch-cache › runtime = edge › should render the correct interception when two distinct layouts share the same path structure

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

   6 | describe('interception-route-prefetch-cache', () => {
   7 |   function runTests({ next }: ReturnType<typeof nextTestSetup>) {
>  8 |     it('should render the correct interception when two distinct layouts share the same path structure', async () => {
     |     ^
   9 |       const browser = await next.browser('/')
  10 |
  11 |       await browser.elementByCss('[href="/foo"]').click()

  at it (e2e/app-dir/interception-route-prefetch-cache/interception-route-prefetch-cache.test.ts:8:5)
  at runTests (e2e/app-dir/interception-route-prefetch-cache/interception-route-prefetch-cache.test.ts:91:5)
  at describe (e2e/app-dir/interception-route-prefetch-cache/interception-route-prefetch-cache.test.ts:90:3)
  at Object.describe (e2e/app-dir/interception-route-prefetch-cache/interception-route-prefetch-cache.test.ts:6:1)

Read more about building and testing Next.js in contributing.md.